Skip to content

Remove mutability from Def::Static - #60124

Merged
bors merged 4 commits into
rust-lang:masterfrom
petrochenkov:stanomut
Apr 21, 2019
Merged

Remove mutability from Def::Static#60124
bors merged 4 commits into
rust-lang:masterfrom
petrochenkov:stanomut

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

Querify TyCtxt::is_static.
Use Mutability instead of bool in foreign statics in AST/HIR.

cc #60110
r? @eddyb

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2019
Comment threadsrc/librustc/ty/util.rs Outdated
@petrochenkovpetrochenkov changed the title [WIP] Remove mutability from Def::StaticRemove mutability from Def::StaticApr 21, 2019
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

Updated.

@eddyb

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 4eb94b4 has been approved by eddyb

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2019
bors added a commit that referenced this pull request Apr 21, 2019
Remove mutability from `Def::Static`
Querify `TyCtxt::is_static`.
Use `Mutability` instead of bool in foreign statics in AST/HIR.
cc #60110
r? @eddyb
@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4eb94b4 with merge 31a75a1...

@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 31a75a1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2019
@bors
bors merged commit 4eb94b4 into rust-lang:masterApr 21, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #60124!

Tested on commit 31a75a1.
Direct link to PR: #60124

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 21, 2019
Tested on commit rust-lang/rust@31a75a1.
Direct link to PR: <rust-lang/rust#60124>
💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
Xanewok added a commit to Xanewok/rust-clippy that referenced this pull request Apr 21, 2019
Xanewok added a commit to Xanewok/rust-clippy that referenced this pull request Apr 21, 2019
bors added a commit to rust-lang/rust-clippy that referenced this pull request Apr 21, 2019
rustup: Use newly-introduced mutability query for statics
Fixes fallout from rust-lang/rust#60124.
cc rust-lang/rust#60154
changelog: none
@XanewokXanewok mentioned this pull request Apr 21, 2019
Xanewok added a commit to Xanewok/rust that referenced this pull request Apr 21, 2019
bors added a commit that referenced this pull request Apr 21, 2019
@petrochenkov
petrochenkov deleted the stanomut branch June 5, 2019 16:33
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
Fixes fallout from rust-lang/rust#60124.
Closes #60154.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@eddyb@bors@rust-highfive@oli-obk