Skip to content

Update Clippy - #60158

Merged
bors merged 1 commit into
rust-lang:masterfrom
Xanewok:update-clippy
Apr 22, 2019
Merged

Update Clippy#60158
bors merged 1 commit into
rust-lang:masterfrom
Xanewok:update-clippy

Conversation

@Xanewok

@XanewokXanewok commented Apr 21, 2019

Copy link
Copy Markdown
Contributor

Fixes fallout from #60124.
Closes#60154.

r? @oli-obk
cc @matthiaskrgr

@rust-highfive

rust-highfive commented Apr 21, 2019

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2019
@matthiaskrgr

matthiaskrgr commented Apr 21, 2019

Copy link
Copy Markdown
Member

I would personally like to have rust-lang/rust-clippy#4013 included (it's waiting for CI right now) to prevent false positives.

with that included r=me if that is possible :p

@Xanewok

Xanewok commented Apr 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Will do, please ping me when/if that lands

@matthiaskrgr

matthiaskrgr commented Apr 21, 2019

Copy link
Copy Markdown
Member

@Xanewok ping, rust-lang/rust-clippy#4013 was merged.

@Xanewok

Xanewok commented Apr 21, 2019

Copy link
Copy Markdown
ContributorAuthor

That was fast, thanks!

@bors r=matthiaskrgr p=1

@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f01015d has been approved by matthiaskrgr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2019
@bors

bors commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f01015d with merge 247b505...

bors added a commit that referenced this pull request Apr 21, 2019
@bors
Auto merge of#60158- Xanewok:update-clippy, r=matthiaskrgr
247b505
Update Clippy
Fixes fallout from #60124.
Closes#60154.
r? @oli-obk
cc @matthiaskrgr
@XanewokXanewok mentioned this pull request Apr 22, 2019
Merged
@bors

bors commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthiaskrgr
Pushing 247b505 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2019
@bors
bors merged commit f01015d into rust-lang:masterApr 22, 2019
@rust-highfive

rust-highfive commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #60158!

Tested on commit 247b505.
Direct link to PR: #60158

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 22, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#60158!
6442cba
Tested on commit rust-lang/rust@247b505.
Direct link to PR: <rust-lang/rust#60158>
🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth@llogiq@mcarton@oli-obk@phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
@Xanewok
Xanewok deleted the update-clippy branch April 22, 2019 07:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#60124

5 participants

@Xanewok@rust-highfive@matthiaskrgr@bors@oli-obk