Skip to content

Breaking update of stdsimd - #60162

Merged
bors merged 1 commit into
rust-lang:masterfrom
gnzlbg:uss
Apr 25, 2019
Merged

Breaking update of stdsimd#60162
bors merged 1 commit into
rust-lang:masterfrom
gnzlbg:uss

Conversation

@gnzlbg

@gnzlbggnzlbg commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

This commit updates stdsimd and contains two breaking changes:

We already did a crater run of 586 but we should do another one here.

r? @alexcrichton

@gnzlbg
Breaking update of stdsimd
c9553f7
This commit updates stdsimd and contains two breaking changes:
* rust-lang/stdarch#733
* rust-lang/stdarch#586
We already did a crater run of 586 but we should do another one here.
@rust-highfive

rust-highfive commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@gnzlbggnzlbg changed the title Breaking update of stdsimd[WIP] Breaking update of stdsimdApr 22, 2019
@gnzlbg

gnzlbg commented Apr 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Switching this to WIP: needs a crater run once CI is green.

@Centril

Centril commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c9553f7 with merge 06a150c7d11500b41499224f165e9de1de096768...

@Centril

Centril commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

Note to self: crater check-only when try completes.

@bors

bors commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-travis
Build commit: 06a150c7d11500b41499224f165e9de1de096768

@Centril

Centril commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

@craterbot run mode=check-only

@craterbot

craterbot commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-60162 created and queued.
🤖 Automatically detected try build 06a150c7d11500b41499224f165e9de1de096768
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2019
@craterbot

craterbot commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-60162 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-60162 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 24, 2019
@Centril

Centril commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

@gnzlbg Looking good!

@alexcrichton Let's move ahead?

@gnzlbggnzlbg changed the title [WIP] Breaking update of stdsimdBreaking update of stdsimdApr 24, 2019
@alexcrichton

alexcrichton commented Apr 24, 2019

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c9553f7 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
@bors

bors commented Apr 25, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c9553f7 with merge 3d720d7...

bors added a commit that referenced this pull request Apr 25, 2019
@bors
Auto merge of#60162- gnzlbg:uss, r=alexcrichton
3d720d7
Breaking update of stdsimd
This commit updates stdsimd and contains two breaking changes:
* rust-lang/stdarch#733
* rust-lang/stdarch#586
We already did a crater run of 586 but we should do another one here.
r? @alexcrichton
@bors

bors commented Apr 25, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 3d720d7 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2019
@bors
bors merged commit c9553f7 into rust-lang:masterApr 25, 2019
@pnkfelixpnkfelix mentioned this pull request Jun 21, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gnzlbg@rust-highfive@Centril@bors@craterbot@alexcrichton