Uh oh!
There was an error while loading. Please reload this page.
Split CommonTypes into CommonTypes and CommonLifetimes - #60195
Merged
Conversation
eddyb
commented
Apr 23, 2019
Contributor
cc @rust-lang/compiler I was thinking |
oli-obk
commented
Apr 23, 2019
Contributor
I like grouping them in their own fields. |
This comment has been minimized.
This comment has been minimized.
varkorforce-pushed
the
commontypes-to-common
branch
from
April 25, 2019 21:05
a79e53b to
7261bd8Comparevarkor
commented
Apr 25, 2019
ContributorAuthor
I've changed it so that they're now grouped by fields: |
CommonTypes to CommonCommonTypes into CommonTypes and CommonLifetimeseddyb
commented
May 1, 2019
Contributor
cc @nikomatsakis This is where "loans" would be nicer because it'd be shorter. @bors r+ |
bors
commented
May 1, 2019
Collaborator
📌 Commit 7261bd8 has been approved by |
bors
commented
May 1, 2019
Collaborator
bors added a commit
that referenced
this pull request
May 1, 2019
Split `CommonTypes` into `CommonTypes` and `CommonLifetimes` The so-called "`CommonTypes`" contains more than just types. r? @eddyb
bors
commented
May 1, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This was referenced May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The so-called "
CommonTypes" contains more than just types.r? @eddyb