Uh oh!
There was an error while loading. Please reload this page.
Constrain all regions in the concrete type for an opaque type - #60449
Merged
Conversation
rust-highfive
commented
May 1, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
matthewjasperforce-pushed
the
impl-trait-outlives
branch
from
May 1, 2019 20:32
19cc7a4 to
d69784eCompareeddyb
commented
May 1, 2019
Contributor
r? @pnkfelix |
This comment has been minimized.
This comment has been minimized.
matthewjasperforce-pushed
the
impl-trait-outlives
branch
from
May 1, 2019 22:30
d69784e to
4a1c0ceComparepnkfelix
reviewed
May 2, 2019
Uh oh!
There was an error while loading. Please reload this page.
pnkfelix
commented
May 2, 2019
Contributor
@bors r+ |
bors
commented
May 2, 2019
Collaborator
📌 Commit 4a1c0cec7b1fd64237de1468ca99f2bad094070d has been approved by |
matthewjasper
commented
May 2, 2019
ContributorAuthor
@bors r- so that I can fix the comment |
matthewjasperforce-pushed
the
impl-trait-outlives
branch
from
May 2, 2019 17:57
4a1c0ce to
d72f4deComparematthewjasper
commented
May 2, 2019
ContributorAuthor
@bors r=pnkfelix |
bors
commented
May 2, 2019
Collaborator
📌 Commit d72f4de has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
…r=pnkfelix Constrain all regions in the concrete type for an opaque type `push_outlives_components` skips some regions in a type, notably the signature of a closure is ignored. Most of the time this is OK, but for opaque types the concrete type is used when checking auto-trait bounds in other functions. cc @nikomatsakis@pnkfelixClosesrust-lang#57464Closesrust-lang#60127
Centril added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
…r=pnkfelix Constrain all regions in the concrete type for an opaque type `push_outlives_components` skips some regions in a type, notably the signature of a closure is ignored. Most of the time this is OK, but for opaque types the concrete type is used when checking auto-trait bounds in other functions. cc @nikomatsakis@pnkfelixClosesrust-lang#57464Closesrust-lang#60127
Centril added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
…r=pnkfelix Constrain all regions in the concrete type for an opaque type `push_outlives_components` skips some regions in a type, notably the signature of a closure is ignored. Most of the time this is OK, but for opaque types the concrete type is used when checking auto-trait bounds in other functions. cc @nikomatsakis@pnkfelixClosesrust-lang#57464Closesrust-lang#60127
Centril added a commit
to Centril/rust
that referenced
this pull request
May 4, 2019
…r=pnkfelix Constrain all regions in the concrete type for an opaque type `push_outlives_components` skips some regions in a type, notably the signature of a closure is ignored. Most of the time this is OK, but for opaque types the concrete type is used when checking auto-trait bounds in other functions. cc @nikomatsakis@pnkfelixClosesrust-lang#57464Closesrust-lang#60127
bors added a commit
that referenced
this pull request
May 4, 2019
Rollup of 9 pull requests Successful merges: - #60429 (Account for paths in incorrect pub qualifier help) - #60449 (Constrain all regions in the concrete type for an opaque type) - #60486 (Place related refactors) - #60513 (Remove -Z borrowck=compare flag) - #60516 (Remove TypeckMir) - #60517 (Reword casting message) - #60520 (Add rustfmt toml) - #60521 (Migrate tidy to rust 2018 edition) - #60527 (Fix async fn lowering ICE with APIT.) Failed merges: r? @ghost
pnkfelix
commented
May 17, 2019
Contributor
based on a user request, nominating for backport to stable. (I am assuming a backport to beta in time for the beta-to-stable-rollover is simply not feasible at this point in the cycle.) |
matthewjasper
commented
May 18, 2019
ContributorAuthor
I've also nominated #60765 because it's essentially the second part of this fix. |
pnkfelix
commented
Jun 6, 2019
Contributor
discussed at T-compiler meeting. Approved for backport to stable channel. |
Centril
commented
Jun 11, 2019
Contributor
Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
push_outlives_componentsskips some regions in a type, notably the signatureof a closure is ignored. Most of the time this is OK, but for opaque types the
concrete type is used when checking auto-trait bounds in other functions.
cc @nikomatsakis@pnkfelix
Closes#57464
Closes#60127