Uh oh!
There was an error while loading. Please reload this page.
Fix more escaping ReScopes - #60765
Merged
Merged
Conversation
This shouldn't be possible any more, but if it does happen, emit an error rather than maybe panicking later when NLL finds a the ReScope. Impl trait in bindings is sufficiently broken that I don't think this breaks anything that works for it.
rust-highfive
commented
May 12, 2019
Contributor
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
commented
May 13, 2019
Contributor
@bors r+ |
bors
commented
May 13, 2019
Collaborator
📌 Commit 9a4f0ab has been approved by |
bors
commented
May 13, 2019
Collaborator
bors added a commit
that referenced
this pull request
May 13, 2019
…i-obk Fix more escaping ReScopes Closes#58840
bors
commented
May 13, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
jsgf
commented
May 14, 2019
Contributor
Will this be in 1.35? |
pnkfelix
commented
Jun 6, 2019
Contributor
discussed in T-compiler meeting. Accepted for backport to stable channel. |
Centril
commented
Jun 11, 2019
Contributor
Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#58840