Skip to content

Resolve match arm ty when arms diverge - #60455

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:resolve-match-arm-ty
May 3, 2019
Merged

Resolve match arm ty when arms diverge#60455
bors merged 1 commit into
rust-lang:masterfrom
estebank:resolve-match-arm-ty

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#58695.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2019
@estebank

Copy link
Copy Markdown
ContributorAuthor

r? @davidtwco

Comment threadsrc/test/ui/match/match-type-err-first-arm.stderr
@davidtwco

Copy link
Copy Markdown
Member

Awesome!

@bors r+ rollup

@bors

bors commented May 2, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 24fddb1 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2019
Centril added a commit to Centril/rust that referenced this pull request May 2, 2019
@CentrilCentril mentioned this pull request May 2, 2019
Centril added a commit to Centril/rust that referenced this pull request May 3, 2019
@CentrilCentril mentioned this pull request May 3, 2019
bors added a commit that referenced this pull request May 3, 2019
Rollup of 12 pull requests
Successful merges:
- #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default)
- #60220 (report fatal errors during doctest parsing)
- #60373 (Tidy: ensure lang features are sorted by since)
- #60388 (Disallow non-explicit elided lifetimes in async fn)
- #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow)
- #60401 (Rename `RUST_LOG` to `RUSTC_LOG`)
- #60409 (Require a trait in the bounds of existential types)
- #60455 (Resolve match arm ty when arms diverge)
- #60457 (Const prop refactoring)
- #60467 (Avoid repeated interning of static strings.)
- #60478 (minor compiler doc tweaks)
- #60501 (Propagate mutability from arguments to local bindings in async fn)
Failed merges:
r? @ghost
@bors
bors merged commit 24fddb1 into rust-lang:masterMay 3, 2019
@estebank
estebank deleted the resolve-match-arm-ty branch November 9, 2023 05:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing type in match arms have incompatible types diagnostic

5 participants

@estebank@rust-highfive@davidtwco@bors@michaelwoerister