Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #60510
Merged
Merged
Conversation
`file_metadata_raw` interns the strings `"<unknown>"` and `""` very frequently. This commit avoids that, which reduces the number of symbols interned significantly and reduces instruction counts by up to 0.5% on some workloads.
`find_attr_val(&line, "since")` returns `Some(", issue = ")` when
`line` is set to the following line:
```
[unstable(feature = "checked_duration_since", issue = "58402")]
```
Make `find_attr_val` use regex that is a little bit more
precise (requires `=` after key name).
It still does not handle all cases (e.g., extra leading chars in key
name, or escaped quotes in value), but is good enough for now.Make deprecation lint `ambiguous_associated_items` deny-by-default As requested by r? @Centril cc rust-lang#57644
…rrors, r=QuietMisdreavus report fatal errors during doctest parsing Fixesrust-lang#59557.
… r=Centril Tidy: ensure lang features are sorted by since This is the tidy side of rust-lang#60361. What is left is actually splitting features into groups and sorting by since. This PR also likely to produce a small (a couple of lines) merge conflict with rust-lang#60362. r? @Centril
…ikomatsakis Disallow non-explicit elided lifetimes in async fn Fixrust-lang#60203 r? @nikomatsakis
Do not suggest incorrect syntax on pattern type error due to borrow Fixrust-lang#55174.
Rename `RUST_LOG` to `RUSTC_LOG` cc: rust-lang#57985 I think we should also change these submodules: - rustc-guide - Cargo (rename to `CARGO_LOG`, cc: rust-lang/cargo#6605, rust-lang/cargo#6189) - miri - rls - rustfmt r? @davidtwco
…e, r=oli-obk Require a trait in the bounds of existential types Fixesrust-lang#53090 r? @oli-obk
…vidtwco Resolve match arm ty when arms diverge Fixrust-lang#58695.
… r=oli-obk Const prop refactoring This is rebased on top of rust-lang#60428 so only the top commit is new. This is the refactoring to remove the `mir` field from `ConstPropagator` which is necessary before we can begin to actually propagate constants. r? @oli-obk
…r=davidtwco Avoid repeated interning of static strings. `file_metadata_raw` interns the strings `"<unknown>"` and `""` very frequently. This commit avoids that, which reduces the number of symbols interned significantly and reduces instruction counts by up to 0.5% on some workloads.
minor compiler doc tweaks
…ts, r=cramertj Propagate mutability from arguments to local bindings in async fn Fixesrust-lang#60498 cc @nikomatsakis r? @davidtwco
Centril
commented
May 3, 2019
ContributorAuthor
@bors r+ p=12 |
bors
commented
May 3, 2019
Collaborator
📌 Commit 6f7a1ea has been approved by |
bors
commented
May 3, 2019
Collaborator
bors added a commit
that referenced
this pull request
May 3, 2019
Rollup of 12 pull requests Successful merges: - #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default) - #60220 (report fatal errors during doctest parsing) - #60373 (Tidy: ensure lang features are sorted by since) - #60388 (Disallow non-explicit elided lifetimes in async fn) - #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow) - #60401 (Rename `RUST_LOG` to `RUSTC_LOG`) - #60409 (Require a trait in the bounds of existential types) - #60455 (Resolve match arm ty when arms diverge) - #60457 (Const prop refactoring) - #60467 (Avoid repeated interning of static strings.) - #60478 (minor compiler doc tweaks) - #60501 (Propagate mutability from arguments to local bindings in async fn) Failed merges: r? @ghost
bors
commented
May 3, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This was referenced May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ambiguous_associated_itemsdeny-by-default #59928 (Make deprecation lintambiguous_associated_itemsdeny-by-default)RUST_LOGtoRUSTC_LOG#60401 (RenameRUST_LOGtoRUSTC_LOG)Failed merges:
r? @ghost