Skip to content

Stabilize reverse_bits feature - #61364

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:stabilize-reverse_bits
Jun 1, 2019
Merged

Stabilize reverse_bits feature#61364
bors merged 1 commit into
rust-lang:masterfrom
tesuji:stabilize-reverse_bits

Conversation

@tesuji

@tesujitesuji commented May 30, 2019

Copy link
Copy Markdown
Contributor

FCP done in #48763 (comment)

Closes#48763

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbotrustbot added the T-libs-api [DEPRECATED; DO NOT USE] label May 30, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@tesuji
tesujiforce-pushed the stabilize-reverse_bits branch from 3618f88 to 1e2185aCompareMay 30, 2019 18:52
@rust-highfive

rust-highfive commented May 30, 2019

Copy link
Copy Markdown
Contributor

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0e1597bd:start=1559242420714441063,finish=1559242421961996546,duration=1247555483
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:10:16] Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:10:16] Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:10:17] Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:10:17] Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl isize>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25] [00:10:25] [00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl i8>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25] [00:10:25] [00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl i16>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25] [00:10:25] [00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl i32>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25] [00:10:25] [00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl i64>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25] [00:10:25] [00:10:25] error[E0723]: can only call other `const fn` within a `const fn`, but `const num::<impl i128>::reverse_bits` is not stable as `const fn`
[00:10:25] |
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 318 | / macro_rules! wrapping_int_impl {
[00:10:25] 319 | | ($($t:ty)*) => ($(
[00:10:25] 320 | | impl Wrapping<$t> {
[00:10:25] 321 | | doc_comment! {
[00:10:25] ... |
[00:10:25] 528 | | Wrapping(self.0.reverse_bits())
[00:10:25] ... |
[00:10:25] 677 | | )*)
[00:10:25] 678 | | }
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] | |_- in this expansion of `wrapping_int_impl!`
[00:10:25] 679 | [00:10:25] 680 | wrapping_int_impl! { usize u8 u16 u32 u64 u128 isize i8 i16 i32 i64 i128 }
[00:10:25] |
[00:10:25] = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
[00:10:25] = help: add #![feature(const_fn)] to the crate attributes to enable
[00:10:25]

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jonas-schievinkjonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label May 30, 2019
@jonas-schievinkjonas-schievink added this to the 1.37 milestone May 30, 2019
@tesuji

tesuji commented May 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril Do we want to stabilize const fn for {integer}::reverse_bits ?

@tesuji
tesujiforce-pushed the stabilize-reverse_bits branch from 5823a14 to 1c26bbfCompareMay 31, 2019 04:44
@tesuji

tesuji commented May 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Okay, I const-stabilized the <{signed-integer}>::reverse_bits.

@Centril

Centril commented May 31, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 31, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1c26bbf has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019
@tesuji

This comment has been minimized.

Sign in to view
Centril added a commit to Centril/rust that referenced this pull request Jun 1, 2019
@Centril
Rollup merge ofrust-lang#61364- lzutao:stabilize-reverse_bits, r=Ce…
7d3a0dd
…ntril
Stabilize reverse_bits feature
FCP done in rust-lang#48763 (comment)Closesrust-lang#48763
r? @Centril
@CentrilCentril mentioned this pull request Jun 1, 2019
Merged
bors added a commit that referenced this pull request Jun 1, 2019
@bors
Auto merge of#61418- Centril:rollup-yvj33a1, r=Centril
885c7df
Rollup of 8 pull requests
Successful merges:
- #60729 (Expand dynamic drop tests for cases in #47949)
- #61263 (Don't generate div inside header (h4/h3/h...) elements)
- #61364 (Stabilize reverse_bits feature)
- #61375 (Make "panic did not include expected string" message consistent)
- #61387 (Remove ty::BrFresh and RegionConstraintCollector::new_bound)
- #61389 (Remove GlobalArenas and use Arena instead)
- #61391 (Doc comment fixes for `rustc::mir::interpret::InterpretCx`)
- #61403 (Remove unnecessary `-Z continue-parse-after-error` from tests)
Failed merges:
r? @ghost
@bors
bors merged commit 1c26bbf into rust-lang:masterJun 1, 2019
@tesuji
tesuji deleted the stabilize-reverse_bits branch June 1, 2019 09:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CentrilCentril

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.37

Development

Successfully merging this pull request may close these issues.

Tracking issue for reversing the bit pattern in an integer

6 participants

@tesuji@rust-highfive@Centril@bors@jonas-schievink@rustbot