Skip to content

Make "panic did not include expected string" message consistent - #61375

Merged
bors merged 1 commit into
rust-lang:masterfrom
varkor:panic-contains-string-lowercase
Jun 1, 2019
Merged

Make "panic did not include expected string" message consistent#61375
bors merged 1 commit into
rust-lang:masterfrom
varkor:panic-contains-string-lowercase

Conversation

@varkor

Copy link
Copy Markdown
Contributor

Note messages are typically lowercase.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@Centril

Copy link
Copy Markdown
Contributor

r? @Centril r=me rollup with green travis.

@Centril

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 31, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c3febc0 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 1, 2019
…ase, r=Centril
Make "panic did not include expected string" message consistent
Note messages are typically lowercase.
@CentrilCentril mentioned this pull request Jun 1, 2019
bors added a commit that referenced this pull request Jun 1, 2019
Rollup of 8 pull requests
Successful merges:
- #60729 (Expand dynamic drop tests for cases in #47949)
- #61263 (Don't generate div inside header (h4/h3/h...) elements)
- #61364 (Stabilize reverse_bits feature)
- #61375 (Make "panic did not include expected string" message consistent)
- #61387 (Remove ty::BrFresh and RegionConstraintCollector::new_bound)
- #61389 (Remove GlobalArenas and use Arena instead)
- #61391 (Doc comment fixes for `rustc::mir::interpret::InterpretCx`)
- #61403 (Remove unnecessary `-Z continue-parse-after-error` from tests)
Failed merges:
r? @ghost
@bors
bors merged commit c3febc0 into rust-lang:masterJun 1, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@varkor@rust-highfive@Centril@bors@shepmaster