Skip to content

Replace mentions of IRC with Discord - #61531

Closed
radu-matei wants to merge 1 commit into
rust-lang:masterfrom
radu-matei:replace-irc-discord
Closed

Replace mentions of IRC with Discord#61531
radu-matei wants to merge 1 commit into
rust-lang:masterfrom
radu-matei:replace-irc-discord

Conversation

@radu-matei

Copy link
Copy Markdown

closes#61524

One occurrence that requires more attention is in the code of conduct - please make sure it is correctly worded.
Happy to get feedback and reword any other change made.

Thanks!

Signed-off-by: Radu M <root@radu.sh>
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2019

@phanschphansch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits to use https over http

(I don't have perms to give final approval, though)

Comment threadCONTRIBUTING.md
valuable!

[pound-rust]: http://chat.mibbit.com/?server=irc.mozilla.org&channel=%23rust
[rust-discord]: http://discord.gg/rust-lang

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[rust-discord]: http://discord.gg/rust-lang
[rust-discord]: https://discord.gg/rust-lang

Comment threadREADME.md
[IRC]: https://en.wikipedia.org/wiki/Internet_Relay_Chat
[#rust]: irc://irc.mozilla.org/rust
[#rust-beginners]: irc://irc.mozilla.org/rust-beginners
[rust-discord]: http://discord.gg/rust-lang

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[rust-discord]: http://discord.gg/rust-lang
[rust-discord]: https://discord.gg/rust-lang

internals.rust-lang.org. When you encounter bugs, please file issues on the
rust-lang/rust issue tracker.

[rust-discord]: http://discord.gg/rust-lang

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[rust-discord]: http://discord.gg/rust-lang
[rust-discord]: https://discord.gg/rust-lang

@Centril

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@Manishearth

Copy link
Copy Markdown
Member

Note: #rust-libs is still active as a team venue (as is #rust-embedded), they're going to find a new place to go before Mozilla IRC shuts down (there's still time).

Furthermore, #rust, #rust-beginners, and #rust-internals are also somewhat active: I plan to lock them at some point to nudge people to Discord/Freenode, but that's not done yet, and the CoC still applies there.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

I've added this to the core team agenda to discuss on Wednesday; I think we'll probably want to just add Discord versus replacing IRC with it from the CoC.

@Manishearth

Copy link
Copy Markdown
Member

I'm surprised Discord isn't on there already, it is on the website: https://www.rust-lang.org/policies/code-of-conduct

@Mark-Simulacrum

Copy link
Copy Markdown
Member

We discussed this a bit during the core team meeting today and decided that we should remove the code of conduct itself from this repository and instead simply link to https://www.rust-lang.org/policies/code-of-conduct. That way there's a canonical version that we can update without having to update numerous repositories. We'll want to edit the website to include IRC as well.

@steveklabnik

Copy link
Copy Markdown
Contributor

One small note about this: we should keep the files, but have them say "the text lives at this URL". GitHub will say that the project does not have a code of conduct without the file existing.

@tesuji

Copy link
Copy Markdown
Contributor

@radu-matei you have nits to solve.

@joelpalmer

Copy link
Copy Markdown

Hi @radu-matei - this is a ping from Triage. Are there any updates on this?

@JohnTitor

Copy link
Copy Markdown
Member

ping from triage @radu-matei
Unfortunately, we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! Thanks for taking the time to contribute.

@JohnTitorJohnTitor added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2019
@ghostghost mentioned this pull request Oct 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 3, 2019
Replace mentions of IRC with Discord
Revival of rust-lang#61531closesrust-lang#61524
what was the outcome of this? rust-lang#61531 (comment)
should this be changed in this PR as well? rust-lang#61531 (comment)
Centril added a commit to Centril/rust that referenced this pull request Oct 3, 2019
Replace mentions of IRC with Discord
Revival of rust-lang#61531closesrust-lang#61524
what was the outcome of this? rust-lang#61531 (comment)
should this be changed in this PR as well? rust-lang#61531 (comment)
tmandry added a commit to tmandry/rust that referenced this pull request Oct 3, 2019
Replace mentions of IRC with Discord
Revival of rust-lang#61531closesrust-lang#61524
what was the outcome of this? rust-lang#61531 (comment)
should this be changed in this PR as well? rust-lang#61531 (comment)
tmandry added a commit to tmandry/rust that referenced this pull request Oct 3, 2019
Replace mentions of IRC with Discord
Revival of rust-lang#61531closesrust-lang#61524
what was the outcome of this? rust-lang#61531 (comment)
should this be changed in this PR as well? rust-lang#61531 (comment)
@ghost

ghost commented Oct 5, 2019

Copy link
Copy Markdown

We discussed this a bit during the core team meeting today and decided that we should remove the code of conduct itself from this repository and instead simply link to https://www.rust-lang.org/policies/code-of-conduct. That way there's a canonical version that we can update without having to update numerous repositories. We'll want to edit the website to include IRC as well.

@Mark-Simulacrum this never got addressed, right? Is there still an interest?

@Mark-Simulacrum

Copy link
Copy Markdown
Member

I think so, yes. I'm happy to review a PR to relevant repositories.

@ghostghost mentioned this pull request Oct 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
…crum
Replace code of conduct with link
This will replace the code of conduct and link to a single version at https://www.rust-lang.org/conduct.htmlFixesrust-lang#61531 (comment)
r? @Mark-Simulacrum
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace mention of IRC with Discord

11 participants

@radu-matei@rust-highfive@Centril@Manishearth@Mark-Simulacrum@steveklabnik@tesuji@joelpalmer@JohnTitor@phansch@nikomatsakis