Uh oh!
There was an error while loading. Please reload this page.
Pass LLVM linker flags to librustc_llvm build - #61704
Merged
Merged
Conversation
rust-highfive
commented
Jun 9, 2019
Contributor
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
cramertj
commented
Jun 10, 2019
Member
alexcrichton
left a comment
Member
There was a problem hiding this comment.
r=me, just a request for a few more comments!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
petrhosekforce-pushed
the
llvm-linker-flags
branch
from
June 11, 2019 02:51
f56d040 to
48f205dComparepetrhosek
commented
Jun 11, 2019
ContributorAuthor
Is this okay to land? |
alexcrichton
commented
Jun 11, 2019
Member
@bors: r+ |
bors
commented
Jun 11, 2019
Collaborator
📌 Commit 48f205d has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…crichton Pass LLVM linker flags to librustc_llvm build Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
bors added a commit
that referenced
this pull request
Jun 14, 2019
Rollup of 5 pull requests Successful merges: - #61704 (Pass LLVM linker flags to librustc_llvm build) - #61792 (Add ui test for issue 51301) - #61803 (typeck: small refactoring, add 'fn write_resolution') - #61805 (typeck: Fix ICE for blocks in repeat expr count.) - #61818 (Issue #60709 test) Failed merges: r? @ghost
bors
commented
Jun 14, 2019
Collaborator
⌛ Testing commit 48f205d with merge 678414ecedc147867e38caaa1ec31b42ccb40936... |
bors
commented
Jun 14, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Jun 14, 2019
Contributor
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Jun 14, 2019
Member
@bors: retry |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 16, 2019
…crichton Pass LLVM linker flags to librustc_llvm build Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 16, 2019
…crichton Pass LLVM linker flags to librustc_llvm build Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
bors added a commit
that referenced
this pull request
Jun 16, 2019
Rollup of 6 pull requests Successful merges: - #61447 (Add some Vec <-> VecDeque documentation) - #61704 (Pass LLVM linker flags to librustc_llvm build) - #61829 (rustbuild: include llvm-libunwind in dist tarball) - #61832 (update miri) - #61866 (Remove redundant `clone()`s) - #61869 (Cleanup some new active feature gates) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some -L and -l flags may be needed even when building librustc_llvm,
for example when using static libc++ on Linux we may need to manually
specify the library search path and -ldl -lpthread as additional link
dependencies. We pass LLVM linker flags from config to librustc_llvm
build to make sure these cases are handled.