Uh oh!
There was an error while loading. Please reload this page.
typeck: Fix ICE for blocks in repeat expr count. - #61805
Merged
bors merged 1 commit intoJun 15, 2019
Merged
Conversation
varkor
reviewed
Jun 13, 2019
Uh oh!
There was an error while loading. Please reload this page.
This commit extends the work in rust-lang#61698 to get the `DefId` of const parameters from block that resolve to a const parameter (as well as const parameters directly, as it was previously).
davidtwcoforce-pushed
the
ice-const-generic-repeat-expr-count-sequel
branch
from
June 13, 2019 22:34
e4dcf2e to
bc36aabComparevarkor
commented
Jun 13, 2019
Contributor
@bors r+ rollup |
bors
commented
Jun 13, 2019
Collaborator
📌 Commit bc36aab has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
bors added a commit
that referenced
this pull request
Jun 14, 2019
Rollup of 5 pull requests Successful merges: - #61704 (Pass LLVM linker flags to librustc_llvm build) - #61792 (Add ui test for issue 51301) - #61803 (typeck: small refactoring, add 'fn write_resolution') - #61805 (typeck: Fix ICE for blocks in repeat expr count.) - #61818 (Issue #60709 test) Failed merges: r? @ghost
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Centril added a commit
to Centril/rust
that referenced
this pull request
Jun 15, 2019
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
bors added a commit
that referenced
this pull request
Jun 15, 2019
Rollup of 6 pull requests Successful merges: - #61785 (note some safety concerns of raw-ptr-to-ref casts) - #61805 (typeck: Fix ICE for blocks in repeat expr count.) - #61813 (Remove some unnecessary symbol interner ops) - #61824 (in which we decline to lint single-use lifetimes in `derive`d impls) - #61844 (Change `...` to `..=` where applicable) - #61854 (Minor cosmetic improvements to accompany PR 61825) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression.
r? @varkor