Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #61852
Closed
Centril wants to merge 17 commits into
Closed
Conversation
This commit extends the work in rust-lang#61698 to get the `DefId` of const parameters from block that resolve to a const parameter (as well as const parameters directly, as it was previously).
When suggesting borrow, remove useless clones Fixrust-lang#61106.
note some safety concerns of raw-ptr-to-ref casts
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixesrust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
…mbol-ops, r=petrochenkov Remove some unnecessary symbol interner ops * Don't gensym symbols that don't need to worry about colliding with other symbols * Use symbol constants instead of interning string literals in a few places. * Don't generate a module in `__register_diagnostic` r? @petrochenkov
type_alias_enum_variants: fixrust-lang#61801; allow a path pattern to infer Fixrust-lang#61801. Given a type-relative path pattern referring to an enum variant through a type alias, allow inferring the generic argument applied in the expectation set by the scrutinee of a `match` expression. Similar issues may exist for `let` statements but I don't know how to test for that since `PhantomData<T>` is necessary...) The gist of the problem here was that `resolve_ty_and_res_ufcs` was called twice which is apparently no good... It is possible that this PR is papering over some deeper problem, but that is beyond my knowledge of the compiler. r? @petrochenkov cc @eddyb@alexreg cc rust-lang#61682 cc rust-lang#49683
Change `...` to `..=` where applicable This is mainly to fixrust-lang#61816, but I decided to manually check a few thousand `...` throughout the code base to check for any other cases. I think I found a documentation bug in `src\libsyntax\ast.rs` where both `1..` and `1...` where mentioned. If there is internal support for both `1..` and `1..=` (that can exist before error handling gets to it), then I can add that back. There were some other cases that look like `// struct Closure<'l0...'li, T0...Tj, CK, CS, U0...Uk> {`, `// <P0 as Trait<P1...Pn>>::Foo: 'a`, and `assert!(min <= max, "discriminant range is {}...{}", min, max);`, but I am not sure if I should change those. There are a bunch of cases in the `/test/` directory that could be changed, but I presume I should just leave those be.
Centril
commented
Jun 14, 2019
ContributorAuthor
@bors r+ p=6 rollup=never |
bors
commented
Jun 14, 2019
Collaborator
📌 Commit 4b528fe has been approved by |
bors
commented
Jun 14, 2019
Collaborator
⌛ Testing commit 4b528fe with merge 1954863b424d3a4b31b0bce35fb8a413c13d9847... |
bors
commented
Jun 14, 2019
Collaborator
💔 Test failed - status-appveyor |
Centril
commented
Jun 14, 2019
ContributorAuthor
@bors treeclosed=100 |
Centril
commented
Jun 14, 2019
ContributorAuthor
@bors retry |
Centril
commented
Jun 14, 2019
ContributorAuthor
@bors p=200 |
bors
commented
Jun 14, 2019
Collaborator
⌛ Testing commit 4b528fe with merge 76fd2fa058e33048ded87b00eb132edcfa6da362... |
bors
commented
Jun 14, 2019
Collaborator
💔 Test failed - status-appveyor |
emilyalbini
commented
Jun 15, 2019
Member
@bors treeclosed- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
...to..=where applicable #61844 (Change...to..=where applicable)Failed merges:
r? @ghost