Skip to content

Explicit error message for async recursion. - #62871

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:async-recursion-error
Jul 29, 2019
Merged

Explicit error message for async recursion.#62871
bors merged 1 commit into
rust-lang:masterfrom
gilescope:async-recursion-error

Conversation

@gilescope

@gilescopegilescope commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

Attempt at clearer error message when async recusion is attempted. In response to #62539 (and #53690).

@rust-highfive

rust-highfive commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2019
@gilescope

gilescope commented Jul 22, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@nikomatsakis thoughts on the extened error explanation? I made it simple enough that I'd be able to follow it. I'm tempted to put the link to the async book in the extended error info rather than directly in the error message as there's now two "For more info see" in the current message.

@petrochenkov

petrochenkov commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

r? @cramertj

@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/error_codes.rs Outdated
Comment threadsrc/librustc_typeck/error_codes.rs Outdated
Comment threadsrc/test/ui/generator/async-recursion-forbid.rs Outdated
Comment threadsrc/test/ui/generator/async-recursion-forbid.rs Outdated
Comment threadsrc/test/ui/generator/async-recursion-forbid.rs Outdated
@Centril

Centril commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

r? @Centril since I already did a review... :)

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
gilescopeforce-pushed the async-recursion-error branch from d1c1546 to 1effdd2CompareJuly 23, 2019 19:13
@Centril

This comment has been minimized.

Sign in to view
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
gilescopeforce-pushed the async-recursion-error branch from b7910c9 to 7c7f7a3CompareJuly 24, 2019 07:11
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope

gilescope commented Jul 24, 2019

Copy link
Copy Markdown
ContributorAuthor

I seem to have managed to repro #57151 accidentally. Could some one kick bors and just confirm this is repeatable. If so will start digging...

@CentrilCentril closed this Jul 24, 2019
@CentrilCentril reopened this Jul 24, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@estebank

This comment has been minimized.

Sign in to view
@GuillaumeGomez

This comment has been minimized.

Sign in to view
nikomatsakis
nikomatsakis approved these changes Jul 25, 2019
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm!

Comment threadsrc/librustc_typeck/error_codes.rs Outdated
Comment threadsrc/librustc_typeck/error_codes.rs Outdated
@gilescope

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@gilescopegilescope mentioned this pull request Jul 26, 2019
Merged
@gilescope
gilescopeforce-pushed the async-recursion-error branch from e82c375 to 2c94203CompareJuly 26, 2019 05:28
@rust-highfive

This comment has been minimized.

Sign in to view
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
@Centril
Rollup merge ofrust-lang#63002- gilescope:better-build-diagnostics,…
8882e42
… r=Mark-Simulacrum
error_index_generator should output stdout/stderr when it panics.
**bootstrap change**
Call error_index_generator tool using run_quiet which will additionally print std out and std err of the command when it returns an error.
(was `run` uses `run_silent` under the covers.)
Why: PR rust-lang#62871 is hitting a build error but the panic isn't getting shown so its unclear what the problem is.
@ollie27

This comment has been minimized.

Sign in to view
@gilescope
gilescopeforce-pushed the async-recursion-error branch from 2c94203 to eaffe57CompareJuly 28, 2019 05:20
@gilescope

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
gilescopeforce-pushed the async-recursion-error branch from eaffe57 to d9969d0CompareJuly 28, 2019 07:33
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope@Centril
Better recursive async fn error message.
4b1d404
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@gilescope
gilescopeforce-pushed the async-recursion-error branch from d9969d0 to 4b1d404CompareJuly 28, 2019 16:04
@gilescope

gilescope commented Jul 28, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @ollie27 for spotting that. Stick a fork in the PR - I think it's done.

@Centril

Centril commented Jul 28, 2019

Copy link
Copy Markdown
Contributor

Indeed it is, thanks!

@bors r+

@bors

bors commented Jul 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 4b1d404 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019
@Centril
Rollup merge ofrust-lang#62871- gilescope:async-recursion-error, r=…
2ac9b89
…Centril
Explicit error message for async recursion.
Attempt at clearer error message when async recusion is attempted. In response to rust-lang#62539 (and rust-lang#53690).
@CentrilCentril mentioned this pull request Jul 28, 2019
Merged
bors added a commit that referenced this pull request Jul 28, 2019
@bors
Auto merge of#63090- Centril:rollup-xnjwm2h, r=Centril
c7312fe
Rollup of 8 pull requests
Successful merges:
- #61856 (Lint attributes on function arguments)
- #62360 (Document that ManuallyDrop::drop should not called more than once)
- #62392 (Update minifier-rs version)
- #62871 (Explicit error message for async recursion.)
- #62995 (Avoid ICE when suggestion span is at Eof)
- #63053 (SystemTime docs: recommend Instant for elapsed time)
- #63081 (tidy: Cleanup the directory whitelist)
- #63088 (Remove anonymous_parameters from unrelated test)
Failed merges:
r? @ghost
@bors
bors merged commit 4b1d404 into rust-lang:masterJul 29, 2019
@CentrilCentril mentioned this pull request Jul 29, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cramertjcramertjcramertj left review comments
@nikomatsakisnikomatsakisnikomatsakis approved these changes
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gilescope@rust-highfive@petrochenkov@Centril@estebank@GuillaumeGomez@ollie27@bors@nikomatsakis@cramertj