Uh oh!
There was an error while loading. Please reload this page.
Avoid ICE when suggestion span is at Eof - #62995
Merged
Merged
Conversation
rust-highfive
commented
Jul 25, 2019
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Jul 25, 2019
ContributorAuthor
Fun: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
issue-62973
branch
2 times, most recently
from
July 26, 2019 01:31
49754fc to
b2aa095Compare
This comment has been minimized.
This comment has been minimized.
dwrensha
commented
Jul 26, 2019
Contributor
For what it's worth, here is a way to trigger the bug with fewer trailing newlines: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4cce30e8d42e50ab4eb2a3efe1b2c5b0 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
varkor
commented
Jul 28, 2019
Contributor
@bors r+ |
bors
commented
Jul 28, 2019
Collaborator
📌 Commit 6263eb4 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 28, 2019
Avoid ICE when suggestion span is at Eof Fixrust-lang#62973.
bors added a commit
that referenced
this pull request
Jul 28, 2019
Rollup of 8 pull requests Successful merges: - #61856 (Lint attributes on function arguments) - #62360 (Document that ManuallyDrop::drop should not called more than once) - #62392 (Update minifier-rs version) - #62871 (Explicit error message for async recursion.) - #62995 (Avoid ICE when suggestion span is at Eof) - #63053 (SystemTime docs: recommend Instant for elapsed time) - #63081 (tidy: Cleanup the directory whitelist) - #63088 (Remove anonymous_parameters from unrelated test) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#62973.