Skip to content

Cleanup save-analysis JsonDumper - #62979

Merged
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:json-dumper-pretty
Jul 27, 2019
Merged

Cleanup save-analysis JsonDumper#62979
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:json-dumper-pretty

Conversation

@Mark-Simulacrum

Copy link
Copy Markdown
Member

No description provided.

The Dumper no longer has anything to do specifically with JSON, it
merely represents processing into an `Analysis` output.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@Xanewok

Copy link
Copy Markdown
Contributor

Looks good, thanks!

@bors r+

@bors

bors commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 68c0ba2 has been approved by Xanewok

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
@CentrilCentril mentioned this pull request Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
@CentrilCentril mentioned this pull request Jul 26, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019
@CentrilCentril mentioned this pull request Jul 27, 2019
bors added a commit that referenced this pull request Jul 27, 2019
Rollup of 6 pull requests
Successful merges:
- #62423 (Fix cycle error with existential types)
- #62979 (Cleanup save-analysis JsonDumper)
- #62982 (Don't access a static just for its size and alignment)
- #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
- #63014 (Stop bare trait lint applying to macro call sites)
- #63036 (Add lib section to rustc_lexer's Cargo.toml)
Failed merges:
r? @ghost
@bors
bors merged commit 68c0ba2 into rust-lang:masterJul 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Mark-Simulacrum@rust-highfive@Xanewok@bors@eddyb