Uh oh!
There was an error while loading. Please reload this page.
Stop bare trait lint applying to macro call sites - #63014
Merged
bors merged 2 commits intoJul 27, 2019
Conversation
This commit adds a reproduction of the error reported in servo which demonstrates the current, incorrect behaviour. Co-authored-by: Rémy Rakić <remy.rakic@gmail.com>
This commit implements a hacky fix for detecting when a span is pointing at a macro call site so that bare trait lints are not made incorrectly.
estebank
commented
Jul 26, 2019
Contributor
The code seems correct, but the I'm not sure about the repro. What is the output for that test without the patch applied? |
davidtwco
commented
Jul 26, 2019
MemberAuthor
You can see it in the test output from the first commit (44bf6b6). |
estebank
commented
Jul 26, 2019
Contributor
@bors r+ |
bors
commented
Jul 26, 2019
Collaborator
📌 Commit cae8680 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
…gestion, r=estebank Stop bare trait lint applying to macro call sites Fixesrust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way. r? @estebank
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 26, 2019
…gestion, r=estebank Stop bare trait lint applying to macro call sites Fixesrust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way. r? @estebank
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 27, 2019
…gestion, r=estebank Stop bare trait lint applying to macro call sites Fixesrust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way. r? @estebank
Centril added a commit
to Centril/rust
that referenced
this pull request
Jul 27, 2019
…gestion, r=estebank Stop bare trait lint applying to macro call sites Fixesrust-lang#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way. r? @estebank
bors added a commit
that referenced
this pull request
Jul 27, 2019
Rollup of 6 pull requests Successful merges: - #62423 (Fix cycle error with existential types) - #62979 (Cleanup save-analysis JsonDumper) - #62982 (Don't access a static just for its size and alignment) - #63013 (add `repr(transparent)` to `IoSliceMut` where missing) - #63014 (Stop bare trait lint applying to macro call sites) - #63036 (Add lib section to rustc_lexer's Cargo.toml) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#61963. Apologies for the delay with in fixing this. If anyone has a better idea how to detect this macro call site case, I'd be happy to fix this in a more robust, less hacky way.
r? @estebank