Skip to content

legacy_directory_ownership -> hard error - #63241

Closed
Centril wants to merge 1 commit into
rust-lang:masterfrom
Centril:ldo-error
Closed

legacy_directory_ownership -> hard error#63241
Centril wants to merge 1 commit into
rust-lang:masterfrom
Centril:ldo-error

Conversation

@Centril

@CentrilCentril commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2019
@bors

bors commented Aug 3, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #63234) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss

ehuss commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

Apologies for butting in, but I have some questions about this.
Is this code path even possible? I can't find any UI tests, and I can't figure out a way to trigger it. It looks to have been mostly removed in #46531. The original tests were further removed via #47298.

@Centril

Copy link
Copy Markdown
ContributorAuthor

I have no idea; I was also surprised there were no tests... I guess crater will show if anyone uses it or not =)

@ehuss

ehuss commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

AFAICT, there are two places where UnownedViaMod can be created: submod_path and InvocationCollector. Both only seem to create it when there is a valid #[path] attribute with a value that fails to produce a file_name() or to_str(), both which shouldn't be possible AFAIK (that is, invalid unicode, or an empty string or root path, all which should fail in other ways).

@Centril

Copy link
Copy Markdown
ContributorAuthor

Rolled up into #63247.

@CentrilCentril closed this Aug 3, 2019
@Centril
Centril deleted the ldo-error branch August 3, 2019 20:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

legacy_directory_ownership future-compatibility warnings

5 participants

@Centril@bors@ehuss@petrochenkov@rust-highfive