Uh oh!
There was an error while loading. Please reload this page.
Transition future compat lints to {ERROR, DENY} - #63247
Conversation
Centril
commented
Aug 3, 2019
@bors try |
bors
commented
Aug 3, 2019
Transition some C-future-compatibility lints to {ERROR, DENY}
Closes#40107 (ERROR).
Closes#39207 (ERROR).
Closes#37872 (ERROR).
Closes#36887 (ERROR).
Closes#36247 (ERROR.
Closes#42238 (ERROR).
Transitions #59014 (DENY).
Transitions #57571 (DENY).
Closes#60210 (ERROR).
Transitions #35203 (DENY).
r? @petrochenkovrust-highfive
commented
Aug 3, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Aug 3, 2019
☀️ Try build successful - checks-azure |
Centril
commented
Aug 3, 2019
@craterbot run mode=check-only |
craterbot
commented
Aug 3, 2019
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Aug 12, 2019
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
1 similar comment
craterbot
commented
Aug 13, 2019
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
petrochenkov
commented
Sep 1, 2019
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bjorn3
commented
Sep 15, 2019
Looking at some random regressions, it seems almost all errors are: "error: defaults for type parameters are only allowed in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Centril
commented
Sep 28, 2019
(Working on a program to do the triage for me... https://xkcd.com/974/) |
Raw reportcrates.ioerror: a macro named |
Some early conclusions:
The rest need some more thought... What do you think? |
Centril
commented
Sep 28, 2019
In case anyone finds it useful, my quickly hacked together program is: https://github.com/Centril/crater-cat-errors. |
petrochenkov
commented
Sep 29, 2019
Could you move everything with >=5 regressions on crates.io to deny-by-default lints? (Including previously hard-coded warnings.) |
petrochenkov
commented
Sep 29, 2019
Could you also update the PR description? |
JohnCSimon
commented
Oct 5, 2019
Ping from triage. |
Dylan-DPC-zz
commented
Oct 10, 2019
Closing this after a discussion with @Centril |
Transition future compat lints to {ERROR, DENY} - Take 2
Follow up to rust-lang#63247 implementing rust-lang#63247 (comment).
- `legacy_ctor_visibility` (ERROR) -- closesrust-lang#39207
- `legacy_directory_ownership` (ERROR) -- closesrust-lang#37872
- `safe_extern_static` (ERROR) -- closesrust-lang#36247
- `parenthesized_params_in_types_and_modules` (ERROR) -- closesrust-lang#42238
- `duplicate_macro_exports` (ERROR)
- `nested_impl_trait` (ERROR) -- closesrust-lang#59014
- `ill_formed_attribute_input` (DENY) -- transitions rust-lang#57571
- `patterns_in_fns_without_body` (DENY) -- transitions rust-lang#35203
r? @varkor
cc @petrochenkovTransition future compat lints to {ERROR, DENY} - Take 2
Follow up to rust-lang#63247 implementing rust-lang#63247 (comment).
- `legacy_ctor_visibility` (ERROR) -- closesrust-lang#39207
- `legacy_directory_ownership` (ERROR) -- closesrust-lang#37872
- `safe_extern_static` (ERROR) -- closesrust-lang#36247
- `parenthesized_params_in_types_and_modules` (ERROR) -- closesrust-lang#42238
- `duplicate_macro_exports` (ERROR)
- `nested_impl_trait` (ERROR) -- closesrust-lang#59014
- `ill_formed_attribute_input` (DENY) -- transitions rust-lang#57571
- `patterns_in_fns_without_body` (DENY) -- transitions rust-lang#35203
r? @varkor
cc @petrochenkov
Closes#40107 (ERROR).
Closes#39207 (ERROR).
Closes#37872 (ERROR).
Closes#36887 (ERROR).
Closes#36247 (ERROR).
Closes#42238 (ERROR).
Closes#60210 (ERROR).
Transitions #59014 (DENY).
Transitions #57571 (DENY).
Transitions #35203 (DENY).
r? @petrochenkov