Skip to content

Remove uses of mem::uninitialized() from cloudabi - #63546

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:clouldabi-maybeuninit
Aug 15, 2019
Merged

Remove uses of mem::uninitialized() from cloudabi#63546
bors merged 1 commit into
rust-lang:masterfrom
tesuji:clouldabi-maybeuninit

Conversation

@tesuji

@tesujitesuji commented Aug 14, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR removes uses of mem::uninitialized from cloudabi module,
excluding the layout test in src/libstd/sys/cloudabi/abi/cloudabi.rs.

r? @RalfJung
cc @EdSchouten
cc #62397

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2019
RalfJung
RalfJung reviewed Aug 14, 2019
View reviewed changes
Comment threadsrc/libstd/sys/cloudabi/abi/cloudabi.rs Outdated
RalfJung
RalfJung reviewed Aug 14, 2019
View reviewed changes
Comment threadsrc/libstd/sys/cloudabi/thread.rs Outdated
@RalfJung

RalfJung commented Aug 14, 2019

Copy link
Copy Markdown
Member

This looks good other than the nits, but I know nothing about CloudABI. @alexcrichton can I just r+ this when it looks reasonable, or what do we do with exotic platforms?

@xen0n

xen0n commented Aug 14, 2019

Copy link
Copy Markdown
Contributor

Before it's too late, let's fix the typo in the commit message and PR title, should one day people grep the revision log for archaeology...

@tesuji
tesujiforce-pushed the clouldabi-maybeuninit branch from 1883b89 to d5bedf5CompareAugust 14, 2019 08:58
@tesujitesuji changed the title Remove uses of mem::uninitialized() from clouldabiRemove uses of mem::uninitialized() from cloudabiAug 14, 2019
@alexcrichton

alexcrichton commented Aug 14, 2019

Copy link
Copy Markdown
Member

Yes this is fine to r+ when ready, the maintainer (@EdSchouten) has been cc'd so we can wait a bit for them to take a look but otherwise we don't strictly review these platforms.

RalfJung
RalfJung approved these changes Aug 14, 2019
View reviewed changes

@RalfJungRalfJung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me any time (but I think there will be conflicts when #63534 lands)

@bors

bors commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #63534) made this pull request unmergeable. Please resolve the merge conflicts.

@tesuji
tesujiforce-pushed the clouldabi-maybeuninit branch from d5bedf5 to b49c0dbCompareAugust 15, 2019 01:49
@RalfJung

RalfJung commented Aug 15, 2019

Copy link
Copy Markdown
Member

@lzutao force-pushes don't trigger notifications, so please let the reviewer know when you did them so that they can take another look.

RalfJung
RalfJung reviewed Aug 15, 2019
View reviewed changes
Comment threadsrc/libstd/sys/cloudabi/abi/cloudabi.rs Outdated
@tesuji
tesujiforce-pushed the clouldabi-maybeuninit branch from b49c0db to 6e8639aCompareAugust 15, 2019 09:05
@RalfJung

RalfJung commented Aug 15, 2019

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 6e8639a has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019
@Centril
Rollup merge ofrust-lang#63546- lzutao:clouldabi-maybeuninit, r=Ral…
87e3393
…fJung
Remove uses of `mem::uninitialized()` from cloudabi
This PR removes uses of `mem::uninitialized` from `cloudabi` module,
excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`.
r? @RalfJung
cc @EdSchouten
cc rust-lang#62397
@CentrilCentril mentioned this pull request Aug 15, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019
@Centril
Rollup merge ofrust-lang#63546- lzutao:clouldabi-maybeuninit, r=Ral…
e452738
…fJung
Remove uses of `mem::uninitialized()` from cloudabi
This PR removes uses of `mem::uninitialized` from `cloudabi` module,
excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`.
r? @RalfJung
cc @EdSchouten
cc rust-lang#62397
@CentrilCentril mentioned this pull request Aug 15, 2019
Merged
bors added a commit that referenced this pull request Aug 15, 2019
@bors
Auto merge of#63592- Centril:rollup-7c6dg3e, r=Centril
f7af19c
Rollup of 9 pull requests
Successful merges:
- #63155 (Add UWP MSVC targets)
- #63165 (Add builtin targets for mips64(el)-unknown-linux-muslabi64)
- #63306 (Adapt AddRetag for shallow retagging)
- #63467 (Add Catalyst (iOS apps running on macOS) target)
- #63546 (Remove uses of `mem::uninitialized()` from cloudabi)
- #63572 (remove unused Level::PhaseFatal)
- #63577 (Test HRTB issue accepted by compiler)
- #63582 (Fix ICE #63226)
- #63586 (cleanup: Remove `Spanned` where possible)
Failed merges:
r? @ghost
@bors

bors commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #63592) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2019
@bors
bors merged commit 6e8639a into rust-lang:masterAug 15, 2019
@tesuji
tesuji deleted the clouldabi-maybeuninit branch August 15, 2019 16:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung approved these changes

Assignees

@RalfJungRalfJung

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tesuji@RalfJung@xen0n@alexcrichton@bors@rust-highfive