Skip to content

Fix ICE #63226 - #63582

Merged
bors merged 4 commits into
rust-lang:masterfrom
JohnTitor:fix-ice-63226
Aug 15, 2019
Merged

Fix ICE #63226#63582
bors merged 4 commits into
rust-lang:masterfrom
JohnTitor:fix-ice-63226

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2019
Comment threadsrc/librustc/middle/reachable.rs Outdated
Comment threadsrc/librustc/middle/reachable.rs Outdated
Comment threadsrc/librustc/middle/reachable.rs
Comment threadsrc/test/ui/issues/issue-63226.rs
Comment threadsrc/librustc/middle/reachable.rs Outdated
Comment threadsrc/librustc/middle/reachable.rs Outdated
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7adb20e has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2019
@CentrilCentril mentioned this pull request Aug 15, 2019
@CentrilCentril mentioned this pull request Aug 15, 2019
bors added a commit that referenced this pull request Aug 15, 2019
Rollup of 9 pull requests
Successful merges:
- #63155 (Add UWP MSVC targets)
- #63165 (Add builtin targets for mips64(el)-unknown-linux-muslabi64)
- #63306 (Adapt AddRetag for shallow retagging)
- #63467 (Add Catalyst (iOS apps running on macOS) target)
- #63546 (Remove uses of `mem::uninitialized()` from cloudabi)
- #63572 (remove unused Level::PhaseFatal)
- #63577 (Test HRTB issue accepted by compiler)
- #63582 (Fix ICE #63226)
- #63586 (cleanup: Remove `Spanned` where possible)
Failed merges:
r? @ghost
@bors
bors merged commit 7adb20e into rust-lang:masterAug 15, 2019
@bors

bors commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #63592) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2019
@JohnTitor
JohnTitor deleted the fix-ice-63226 branch August 15, 2019 17:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE when constructing monomorphic vtable in a static in dependent crate.

5 participants

@JohnTitor@oli-obk@bors@Centril@rust-highfive