Uh oh!
There was an error while loading. Please reload this page.
improve MIPS backend and implement segmented stacks - #6358
Closed
crabtw wants to merge 1 commit into
Closed
Conversation
Closed
brson
commented
May 9, 2013
Contributor
I opened #6367 to batch up pending LLVM patch.s |
brson
commented
May 9, 2013
Contributor
Thanks @crabtw 🐰 |
bors added a commit
that referenced
this pull request
May 10, 2013
I changed ```RED_ZONE_SIZE``` to ```RZ_MAC_32``` because of stack canary failure. Here is a LLVM patch for MIPS segmented stacks. http://people.cs.nctu.edu.tw/~jyyou/rust/mips-segstk.patch Current test results ``` failures: rand::tests::test_rng_seeded_custom_seed2 run::tests::test_forced_destroy_actually_kills run::tests::test_unforced_destroy_actually_kills time::tests::run_tests uv_ll::test::test_uv_ll_struct_size_addrinfo uv_ll::test::test_uv_ll_struct_size_uv_timer_t segfaults: rt::io::option::test::test_option_writer_error rt::local_services::test::unwind rt::sched::test_swap_tasks_then stackwalk::test_simple stackwalk::test_simple_deep ```
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 30, 2021
…in_deref, r=llogiq Fix a wrong suggestion of `ref_in_deref` Fixrust-lang#6358. changelog: Fix a wrong suggestion of `ref_in_deref`
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6360: Fix unary minus highlighting r=matklad a=Veykril Fixesrust-lang#6358 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed
RED_ZONE_SIZEtoRZ_MAC_32because of stack canary failure.Here is a LLVM patch for MIPS segmented stacks.
http://people.cs.nctu.edu.tw/~jyyou/rust/mips-segstk.patch
Current test results