') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add a splay tree implementation to libstd by alexcrichton · Pull Request #6360 · rust-lang/rust · GitHub
Skip to content

Add a splay tree implementation to libstd - #6360

Closed
alexcrichton wants to merge 3 commits into
rust-lang:incomingfrom
alexcrichton:splay-tree
Closed

Add a splay tree implementation to libstd#6360
alexcrichton wants to merge 3 commits into
rust-lang:incomingfrom
alexcrichton:splay-tree

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented May 9, 2013

Copy link
Copy Markdown
Member

I was curious if something like this was possible, and it indeed is!

I didn't want to duplicate a lot of functionality between splay trees and the existing treemap module, so I extracted out a lot of the iterators and implementations into the iterator module.

If this doesn't belong in libstd, it was mostly a proof-of-concept idea anyway. I remember talk about moving the current std away from this repo and into their own repos, so this may just belong elsewhere.

Benchmark-wise, it performs about as well as expected. It's real bad on random input (when compared to TreeMap), and it's better on sequential input than TreeMap most of the time. Although that's not quite representative because splay trees are meant to be used on inputs with mild patterns anyway.

Method naming would love to have #5898 as well...

@pcwalton

pcwalton commented May 10, 2013

Copy link
Copy Markdown
Contributor

This is really well written. Thank you!

I'm not sure how many trees we want in std (soon to be extra) though. We'll need to discuss and make a decision. But either way, please feel free to share this in the Rust package repo when it's ready.

@alexcrichton

alexcrichton commented May 17, 2013

Copy link
Copy Markdown
MemberAuthor

In hopes of keeping the queue smaller, I'm going to close this. I'll keep an eye on the new extra library coming up, and when the time comes around I'll see if this should be added in.

@erickt

erickt commented Aug 10, 2013

Copy link
Copy Markdown
Contributor

@alexcrichton: Did this ever get updated to HEAD?

@alexcrichton

alexcrichton commented Aug 10, 2013

Copy link
Copy Markdown
MemberAuthor

The conclusion was that this was just "one more thing" in libextra which just added more maintenance burden, so it wasn't added. I've got a fork at https://github.com/alexcrichton/rs-splay which I'm trying to update as the compiler evolves though.

I hope to revisit this again once the fate of libextra has been finalized

flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 6, 2020
@bors
Auto merge ofrust-lang#6360- mlegner:mod_one, r=llogiq
a644930
Trigger modulo_one lint also on -1.
Fixesrust-lang#6321.
changelog: trigger `modulo_one` lint also on `-1`
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
@bors@Veykril
Mergerust-lang#6360
35ed3d2
6360: Fix unary minus highlighting r=matklad a=Veykril
Fixesrust-lang#6358
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcrichton@pcwalton@erickt