Skip to content

Add some more tests for underscore imports - #64043

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:underscore-import-tests
Sep 5, 2019
Merged

Add some more tests for underscore imports#64043
bors merged 1 commit into
rust-lang:masterfrom
matthewjasper:underscore-import-tests

Conversation

@matthewjasper

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2019
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Sep 3, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 754a875 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2019
@Centril

Copy link
Copy Markdown
Contributor

(Why are the tests being moved from an RFC-named directory?)
(cc @nikomatsakis -- we should discuss organization sometime ^^)

Centril added a commit to Centril/rust that referenced this pull request Sep 4, 2019
…ts, r=alexcrichton
Add some more tests for underscore imports
@CentrilCentril mentioned this pull request Sep 4, 2019
bors added a commit that referenced this pull request Sep 4, 2019
Rollup of 10 pull requests
Successful merges:
- #63166 (Add Result::cloned{,_err} and Result::copied{,_err})
- #63930 (Account for doc comments coming from proc macros without spans)
- #63985 (Stabilize pin_into_inner in 1.39.0)
- #64023 (libstd fuchsia fixes)
- #64030 (Fix unlock ordering in SGX synchronization primitives)
- #64041 (use TokenStream rather than &[TokenTree] for built-in macros)
- #64043 (Add some more tests for underscore imports)
- #64092 (Update xLTO compatibility table in rustc book.)
- #64120 (Move path parsing earlier)
- #64123 (Added warning around code with reference to uninit bytes)
Failed merges:
r? @ghost
@matthewjasper

Copy link
Copy Markdown
ContributorAuthor

(Why are the tests being moved from an RFC-named directory?)

Not having the RFC name is more common, and the RFC number isn't really helpful once the RFC has been merged.

Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…ts, r=alexcrichton
Add some more tests for underscore imports
@CentrilCentril mentioned this pull request Sep 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
…ts, r=alexcrichton
Add some more tests for underscore imports
@CentrilCentril mentioned this pull request Sep 5, 2019
bors added a commit that referenced this pull request Sep 5, 2019
Rollup of 15 pull requests
Successful merges:
- #62860 (Stabilize checked_duration_since for 1.38.0)
- #63549 (Rev::rposition counts from the wrong end)
- #63985 (Stabilize pin_into_inner in 1.39.0)
- #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection)
- #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`)
- #64038 (Check impl trait substs when checking for recursive types)
- #64043 (Add some more tests for underscore imports)
- #64092 (Update xLTO compatibility table in rustc book.)
- #64110 (Refer to "`self` type" instead of "receiver type")
- #64120 (Move path parsing earlier)
- #64123 (Added warning around code with reference to uninit bytes)
- #64128 (unused_parens: account for or-patterns and `&(mut x)`)
- #64141 (Minimize uses of `LocalInternedString`)
- #64142 (Fix doc links in `std::cmp` module)
- #64148 (fix a few typos in comments)
Failed merges:
r? @ghost
@bors
bors merged commit 754a875 into rust-lang:masterSep 5, 2019
@matthewjasper
matthewjasper deleted the underscore-import-tests branch September 5, 2019 10:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@matthewjasper@rust-highfive@alexcrichton@bors@Centril