Skip to content

unused_parens: account for or-patterns and &(mut x) - #64128

Merged
bors merged 1 commit into
rust-lang:masterfrom
Centril:unused-parens-pat
Sep 5, 2019
Merged

unused_parens: account for or-patterns and &(mut x)#64128
bors merged 1 commit into
rust-lang:masterfrom
Centril:unused-parens-pat

Conversation

@Centril

Copy link
Copy Markdown
Contributor

Fixes#55342.
Fixes#64106.

cc #54883
cc #64111

r? @oli-obk

@CentrilCentril added the F-or_patterns `#![feature(or_patterns)]` label Sep 3, 2019
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2019
@Centril

Copy link
Copy Markdown
ContributorAuthor

Oli is busy; let's try r? @davidtwco

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidtwco

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit e85b181 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
@CentrilCentril mentioned this pull request Sep 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 5, 2019
@CentrilCentril mentioned this pull request Sep 5, 2019
bors added a commit that referenced this pull request Sep 5, 2019
Rollup of 15 pull requests
Successful merges:
- #62860 (Stabilize checked_duration_since for 1.38.0)
- #63549 (Rev::rposition counts from the wrong end)
- #63985 (Stabilize pin_into_inner in 1.39.0)
- #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection)
- #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`)
- #64038 (Check impl trait substs when checking for recursive types)
- #64043 (Add some more tests for underscore imports)
- #64092 (Update xLTO compatibility table in rustc book.)
- #64110 (Refer to "`self` type" instead of "receiver type")
- #64120 (Move path parsing earlier)
- #64123 (Added warning around code with reference to uninit bytes)
- #64128 (unused_parens: account for or-patterns and `&(mut x)`)
- #64141 (Minimize uses of `LocalInternedString`)
- #64142 (Fix doc links in `std::cmp` module)
- #64148 (fix a few typos in comments)
Failed merges:
r? @ghost
@bors
bors merged commit e85b181 into rust-lang:masterSep 5, 2019
@Centril
Centril deleted the unused-parens-pat branch September 5, 2019 06:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-or_patterns`#![feature(or_patterns)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

or_patterns: unused_parens lints erroneously on _a @ (0 | 1) spurious unused_parens warning

5 participants

@Centril@davidtwco@bors@oli-obk@rust-highfive