Uh oh!
There was an error while loading. Please reload this page.
Shrink SubregionOrigin. - #64394
Merged
Merged
Conversation
It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
rust-highfive
commented
Sep 12, 2019
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
nnethercote
commented
Sep 12, 2019
ContributorAuthor
@bors try |
bors
commented
Sep 12, 2019
Collaborator
bors added a commit
that referenced
this pull request
Sep 12, 2019
Shrink `SubregionOrigin`. It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
Closed
bors
commented
Sep 12, 2019
Collaborator
☀️ Try build successful - checks-azure |
nnethercote
commented
Sep 12, 2019
ContributorAuthor
@rust-timer build 1702b17 |
rust-timer
commented
Sep 12, 2019
Collaborator
Success: Queued 1702b17 with parent c9edc02, comparison URL. |
rust-timer
commented
Sep 12, 2019
Collaborator
Finished benchmarking try commit 1702b17, comparison URL. |
nnethercote
commented
Sep 12, 2019
ContributorAuthor
The perf effect is small but clearly beneficial. |
Mark-Simulacrum
commented
Sep 17, 2019
Member
@bors r+ rollup |
bors
commented
Sep 17, 2019
Collaborator
📌 Commit 7f0637d has been approved by |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
… r=Mark-Simulacrum Shrink `SubregionOrigin`. It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
… r=Mark-Simulacrum Shrink `SubregionOrigin`. It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
… r=Mark-Simulacrum Shrink `SubregionOrigin`. It's currently 120 bytes on x86-64, due to one oversized variant (`Subtype`). This commit boxes `Subtype`'s contents, reducing the size of `SubregionOrigin` to 32 bytes. The change speeds things up by avoiding lots of `memcpy` calls, mostly relating to `RegionConstraintData::constraints`, which is a `BTreeMap` with `SubregionOrigin` values.
bors added a commit
that referenced
this pull request
Sep 17, 2019
Rollup of 10 pull requests Successful merges: - #61626 (Get rid of special const intrinsic query in favour of `const_eval`) - #64283 (Updated RELEASES.md for 1.38.0) - #64394 (Shrink `SubregionOrigin`.) - #64429 (Fix failure note `to_str` implementation) - #64436 (improve Vec example soundness in mem::transmute docs) - #64502 (avoid duplicate issues for Miri build failures) - #64505 (Fix inconsistent link formatting) - #64529 (Add an example to Pin::as_mut) - #64541 (document Miri error categories) - #64544 (build-manifest: re-add some comments) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently 120 bytes on x86-64, due to one oversized variant
(
Subtype). This commit boxesSubtype's contents, reducing the sizeof
SubregionOriginto 32 bytes.The change speeds things up by avoiding lots of
memcpycalls, mostlyrelating to
RegionConstraintData::constraints, which is aBTreeMapwith
SubregionOriginvalues.