Uh oh!
There was an error while loading. Please reload this page.
Fix failure note to_str implementation - #64429
Conversation
rust-highfive
commented
Sep 13, 2019
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
afnanenayet
commented
Sep 13, 2019
I looked at the log output for the failing CI build...seems like a lot of errors that aren't related to my change, but I could be wrong. Does this normally happen? |
Mark-Simulacrum
commented
Sep 13, 2019
That's unexpected, but related to this change. We'll need to dig in why; I'll try to spend some time today on that. |
Mark-Simulacrum
commented
Sep 13, 2019
Oh, I see what's happening. The "For more information about this error" piece is being emitted as a failure note rust/src/librustc_errors/lib.rs Lines 692 to 701 in 3287a65 I think adjusting the code here to not print the level_str if the level is FailureNote would work to fix CI here. |
rust-highfive
commented
Sep 15, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Sep 16, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Sep 16, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Sep 16, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
afnanenayet
commented
Sep 16, 2019
@Mark-Simulacrum how can I re-run the CI? I saw the issue that references the build error that just happened for this PR |
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Sep 16, 2019
Ah, and we'll also want to squash the commits into just one. Thanks! |
afnanenayet
commented
Sep 16, 2019
Awesome, I'll fix this up after work. Thanks so much for helping me out with this! |
* Serialize the level to something a little more useful for a failure note struct * Update tests accordingly
4436338 to
02c1b89CompareMark-Simulacrum
commented
Sep 17, 2019
Thanks! @bors r+ rollup |
bors
commented
Sep 17, 2019
📌 Commit 02c1b89 has been approved by |
…json-level, r=Mark-Simulacrum Fix failure note `to_str` implementation Serialize the level to something a little more useful for a failure note struct. This fixesrust-lang#60425.
…json-level, r=Mark-Simulacrum Fix failure note `to_str` implementation Serialize the level to something a little more useful for a failure note struct. This fixesrust-lang#60425.
…json-level, r=Mark-Simulacrum Fix failure note `to_str` implementation Serialize the level to something a little more useful for a failure note struct. This fixesrust-lang#60425.
Rollup of 10 pull requests Successful merges: - #61626 (Get rid of special const intrinsic query in favour of `const_eval`) - #64283 (Updated RELEASES.md for 1.38.0) - #64394 (Shrink `SubregionOrigin`.) - #64429 (Fix failure note `to_str` implementation) - #64436 (improve Vec example soundness in mem::transmute docs) - #64502 (avoid duplicate issues for Miri build failures) - #64505 (Fix inconsistent link formatting) - #64529 (Add an example to Pin::as_mut) - #64541 (document Miri error categories) - #64544 (build-manifest: re-add some comments) Failed merges: r? @ghost
Serialize the level to something a little more useful for a failure note struct. This fixes#60425.