Uh oh!
There was an error while loading. Please reload this page.
Remove raw string literal quotes from error index descriptions - #64422
Merged
Conversation
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
r=me if you can check and confirm src/libsyntax/diagnostics/macros.rs does not need the same fix.
ollie27
commented
Sep 13, 2019
ContributorAuthor
rust/src/libsyntax/diagnostics/macros.rs Line 179 in f43ac06
@bors r=Mark-Simulacrum |
bors
commented
Sep 13, 2019
Collaborator
📌 Commit bd25507 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 13, 2019
…gify, r=Mark-Simulacrum Remove raw string literal quotes from error index descriptions The error index has unnecessary `r##"` and `"##` around the descriptions from rust-lang#63721. Removing the `stringify` call removes them. r? @Mark-Simulacrum
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
…gify, r=Mark-Simulacrum Remove raw string literal quotes from error index descriptions The error index has unnecessary `r##"` and `"##` around the descriptions from rust-lang#63721. Removing the `stringify` call removes them. r? @Mark-Simulacrum
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
…gify, r=Mark-Simulacrum Remove raw string literal quotes from error index descriptions The error index has unnecessary `r##"` and `"##` around the descriptions from rust-lang#63721. Removing the `stringify` call removes them. r? @Mark-Simulacrum
Centril added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
…gify, r=Mark-Simulacrum Remove raw string literal quotes from error index descriptions The error index has unnecessary `r##"` and `"##` around the descriptions from rust-lang#63721. Removing the `stringify` call removes them. r? @Mark-Simulacrum
bors added a commit
that referenced
this pull request
Sep 14, 2019
Rollup of 17 pull requests Successful merges: - #63846 (Added table containing the system calls used by Instant and SystemTime.) - #64116 (Fix minor typo in docs.) - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore) - #64302 (Shrink `ObligationCauseCode`) - #64372 (use randSecure and randABytes) - #64374 (Box `DiagnosticBuilder`.) - #64375 (Fast path for vec.clear/truncate ) - #64378 (Fix inconsistent link formatting.) - #64384 (Trim rustc-workspace-hack) - #64393 ( declare EnvKey before use to fix build error) - #64420 (Inline `mark_neighbours_as_waiting_from`.) - #64422 (Remove raw string literal quotes from error index descriptions) - #64423 (Add self to .mailmap) - #64425 (typo fix) - #64431 (fn ptr is structural match) - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.) - #64439 (fix#64430, confusing `owned_box` error message in no_std build) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error index has unnecessary
r##"and"##around the descriptions from #63721. Removing thestringifycall removes them.r? @Mark-Simulacrum