Skip to content

fn ptr is structural match - #64431

Merged
bors merged 2 commits into
rust-lang:masterfrom
pnkfelix:issue-63479-fnptr-is-structural-match
Sep 14, 2019
Merged

fn ptr is structural match#64431
bors merged 2 commits into
rust-lang:masterfrom
pnkfelix:issue-63479-fnptr-is-structural-match

Conversation

@pnkfelix

@pnkfelixpnkfelix commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.

Fix#63479.

@rust-highfive

rust-highfive commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019
@pnkfelixpnkfelix added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 13, 2019
@varkor

varkor commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c529294 has been approved by varkor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2019
Centril
Centril reviewed Sep 13, 2019
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(A round of nits that you can commit as a batch)
(Was going to say r=me but @varkor was too fast...)

Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Comment threadsrc/test/ui/rfc1445/fn-ptr-is-structurally-matchable.rs
Centril added a commit to Centril/rust that referenced this pull request Sep 13, 2019
@Centril
Rollup merge ofrust-lang#64431- pnkfelix:issue-63479-fnptr-is-struc…
99e9fc1
…tural-match, r=varkor
fn ptr is structural match
Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.
Fixrust-lang#63479.
@CentrilCentril mentioned this pull request Sep 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge ofrust-lang#64431- pnkfelix:issue-63479-fnptr-is-struc…
73e5a8e
…tural-match, r=varkor
fn ptr is structural match
Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.
Fixrust-lang#63479.
@CentrilCentril mentioned this pull request Sep 14, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge ofrust-lang#64431- pnkfelix:issue-63479-fnptr-is-struc…
a51ebc1
…tural-match, r=varkor
fn ptr is structural match
Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.
Fixrust-lang#63479.
@CentrilCentril mentioned this pull request Sep 14, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
@Centril
Rollup merge ofrust-lang#64431- pnkfelix:issue-63479-fnptr-is-struc…
5160e4b
…tural-match, r=varkor
fn ptr is structural match
Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.
Fixrust-lang#63479.
@CentrilCentril mentioned this pull request Sep 14, 2019
Merged
bors added a commit that referenced this pull request Sep 14, 2019
@bors
Auto merge of#64456- Centril:rollup-ytqdwaq, r=Centril
ca3766e
Rollup of 17 pull requests
Successful merges:
- #63846 (Added table containing the system calls used by Instant and SystemTime.)
- #64116 (Fix minor typo in docs.)
- #64203 (A few cosmetic improvements to code & comments in liballoc and libcore)
- #64302 (Shrink `ObligationCauseCode`)
- #64372 (use randSecure and randABytes)
- #64374 (Box `DiagnosticBuilder`.)
- #64375 (Fast path for vec.clear/truncate )
- #64378 (Fix inconsistent link formatting.)
- #64384 (Trim rustc-workspace-hack)
- #64393 ( declare EnvKey before use to fix build error)
- #64420 (Inline `mark_neighbours_as_waiting_from`.)
- #64422 (Remove raw string literal quotes from error index descriptions)
- #64423 (Add self to .mailmap)
- #64425 (typo fix)
- #64431 (fn ptr is structural match)
- #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.)
- #64439 (fix#64430, confusing `owned_box` error message in no_std build)
Failed merges:
r? @ghost
@bors
bors merged commit c529294 into rust-lang:masterSep 14, 2019
@fbstj

fbstj commented Sep 14, 2019

Copy link
Copy Markdown
Contributor

@Centril did your nits from above get tested/committed during that rollup?

@Centril

Centril commented Sep 14, 2019

Copy link
Copy Markdown
Contributor

No, but they were nits, so I don't care a lot. :)

@pnkfelixpnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 19, 2019
@pnkfelix

pnkfelix commented Sep 19, 2019

Copy link
Copy Markdown
ContributorAuthor

discussed at T-compiler meeting; approved for beta backport.

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2019
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@varkorvarkor

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: Matching on function pointers fails when one of the formal params implements custom PartialEq

7 participants

@pnkfelix@rust-highfive@varkor@bors@fbstj@Centril@Mark-Simulacrum