Uh oh!
There was an error while loading. Please reload this page.
syntax: recover trailing | in or-patterns - #64887
Merged
Merged
Conversation
Centrilforce-pushed
the
recover-trailing-vert
branch
2 times, most recently
from
September 29, 2019 04:45
94dae1f to
66c5ad1CompareUh oh!
There was an error while loading. Please reload this page.
Centrilforce-pushed
the
recover-trailing-vert
branch
2 times, most recently
from
September 29, 2019 05:10
d4926a3 to
4a00342CompareCentril
commented
Sep 29, 2019
ContributorAuthor
Added |
Centrilforce-pushed
the
recover-trailing-vert
branch
from
September 29, 2019 05:11
4a00342 to
3eba6c1Compareestebank
commented
Oct 1, 2019
Contributor
@bors r+ |
bors
commented
Oct 1, 2019
Collaborator
📌 Commit 3eba6c1 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 1, 2019
…tebank syntax: recover trailing `|` in or-patterns Fixesrust-lang#64879. For example (this also shows that we are sensitive to the typo `||`): ``` error: a trailing `|` is not allowed in an or-pattern --> $DIR/remove-leading-vert.rs:33:11 | LL | A || => {} | - ^^ help: remove the `||` | | | while parsing this or-pattern starting here | = note: alternatives in or-patterns are separated with `|`, not `||` ``` r? @estebank
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 1, 2019
…tebank syntax: recover trailing `|` in or-patterns Fixesrust-lang#64879. For example (this also shows that we are sensitive to the typo `||`): ``` error: a trailing `|` is not allowed in an or-pattern --> $DIR/remove-leading-vert.rs:33:11 | LL | A || => {} | - ^^ help: remove the `||` | | | while parsing this or-pattern starting here | = note: alternatives in or-patterns are separated with `|`, not `||` ``` r? @estebank
bors added a commit
that referenced
this pull request
Oct 1, 2019
Rollup of 10 pull requests Successful merges: - #63674 (syntax: Support modern attribute syntax in the `meta` matcher) - #63931 (Stabilize macros in some more positions) - #64887 (syntax: recover trailing `|` in or-patterns) - #64895 (async/await: improve not-send errors) - #64896 (Remove legacy grammar) - #64907 (A small amount of tidying-up factored out from PR #64648) - #64928 (Add tests for some issues) - #64930 (Silence unreachable code lint from await desugaring) - #64935 (Improve code clarity) - #64937 (Deduplicate closure type errors) Failed merges: r? @ghost
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#64879.
For example (this also shows that we are sensitive to the typo
||):r? @estebank