Skip to content

A small amount of tidying-up factored out from PR #64648 - #64907

Merged
bors merged 6 commits into
rust-lang:masterfrom
alexreg:tidy-up
Oct 1, 2019
Merged

A small amount of tidying-up factored out from PR #64648#64907
bors merged 6 commits into
rust-lang:masterfrom
alexreg:tidy-up

Conversation

@alexreg

Copy link
Copy Markdown
Contributor

As requested by @Mark-Simulacrum, I put this in a separate commit to make it easier to review. (As far as I can tell, no violations of the policy here, and they are simply in a separate PR because they're not directly related to the import of that PR.)

r? @Mark-Simulacrum

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2019
Comment threadsrc/libsyntax_pos/lib.rs
Comment threadsrc/libsyntax_pos/lib.rs
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 33ed03f has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
A small amount of tidying-up factored out from PR rust-lang#64648
As requested by @Mark-Simulacrum, I put this in a separate commit to make it easier to review. (As far as I can tell, no violations of the policy here, and they are simply in a separate PR because they're not directly related to the import of that PR.)
r? @Mark-Simulacrum
@CentrilCentril mentioned this pull request Oct 1, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
A small amount of tidying-up factored out from PR rust-lang#64648
As requested by @Mark-Simulacrum, I put this in a separate commit to make it easier to review. (As far as I can tell, no violations of the policy here, and they are simply in a separate PR because they're not directly related to the import of that PR.)
r? @Mark-Simulacrum
@CentrilCentril mentioned this pull request Oct 1, 2019
bors added a commit that referenced this pull request Oct 1, 2019
Rollup of 10 pull requests
Successful merges:
- #63674 (syntax: Support modern attribute syntax in the `meta` matcher)
- #63931 (Stabilize macros in some more positions)
- #64887 (syntax: recover trailing `|` in or-patterns)
- #64895 (async/await: improve not-send errors)
- #64896 (Remove legacy grammar)
- #64907 (A small amount of tidying-up factored out from PR #64648)
- #64928 (Add tests for some issues)
- #64930 (Silence unreachable code lint from await desugaring)
- #64935 (Improve code clarity)
- #64937 (Deduplicate closure type errors)
Failed merges:
r? @ghost
@bors
bors merged commit 33ed03f into rust-lang:masterOct 1, 2019
@alexreg

Copy link
Copy Markdown
ContributorAuthor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@alexreg@Mark-Simulacrum@bors@rust-highfive