Skip to content

Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions - #64922

Merged
bors merged 1 commit into
rust-lang:masterfrom
spastorino:make-place-builder
Oct 2, 2019
Merged

Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions#64922
bors merged 1 commit into
rust-lang:masterfrom
spastorino:make-place-builder

Conversation

@spastorino

@spastorinospastorino commented Sep 30, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2019
@spastorino

spastorino commented Sep 30, 2019

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 897aa23dc68fe81b634aaf72853b5fe8e14024e3 with merge 312f214bc826aabf7836d8893cdc87931dac5e2d...

oli-obk
oli-obk requested changes Sep 30, 2019
View reviewed changes
Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
@bors

bors commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: 312f214bc826aabf7836d8893cdc87931dac5e2d (312f214bc826aabf7836d8893cdc87931dac5e2d)

@rust-timer

rust-timer commented Sep 30, 2019

Copy link
Copy Markdown
Collaborator

Queued 312f214bc826aabf7836d8893cdc87931dac5e2d with parent e0436d9, future comparison URL.

@rust-timer

rust-timer commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit 312f214bc826aabf7836d8893cdc87931dac5e2d, comparison URL.

@spastorino

spastorino commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@bors

bors commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit ff717bba4cd1cd1e68846c5271683e175bc8e76d with merge 909a0a18abbca972f3de8907328564b5b7e2c01f...

@oli-obk

oli-obk commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

@rust-timer abort

@oli-obkoli-obk closed this Oct 1, 2019
@oli-obkoli-obk reopened this Oct 1, 2019
@mati865

mati865 commented Oct 1, 2019

Copy link
Copy Markdown
Member

@oli-obk perf.rlo has crashed

@Centril

Centril commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2019
@oli-obk

oli-obk commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

I don't want to try or perf run, I wanted to abort it 😆

@oli-obkoli-obk closed this Oct 1, 2019
@oli-obkoli-obk reopened this Oct 1, 2019
@Centril

Centril commented Oct 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@oli-obk My command was unrelated ;) I wanted to make my rollup go test (bors queue was stuck).

oli-obk
oli-obk reviewed Oct 1, 2019
View reviewed changes
Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
nikomatsakis
nikomatsakis approved these changes Oct 2, 2019
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a nit (request for a comment). I also mentioned pulling this into its own file, but after reading the whole PR I'm not sure if it makes sense or not.

Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
Comment threadsrc/librustc_mir/build/expr/as_place.rs Outdated
@nikomatsakis

nikomatsakis commented Oct 2, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

r=me with comments -- unless @oli-obk would prefer a chance to review, of course

@spastorino

spastorino commented Oct 2, 2019

Copy link
Copy Markdown
MemberAuthor

@bors r=nikomatsakis

@bors

bors commented Oct 2, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 79dc862 has been approved by nikomatsakis

Centril added a commit to Centril/rust that referenced this pull request Oct 2, 2019
@Centril
Rollup merge ofrust-lang#64922- spastorino:make-place-builder, r=ni…
19d035c
…komatsakis
Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions
r? @oli-obk
@CentrilCentril mentioned this pull request Oct 2, 2019
Merged
bors added a commit that referenced this pull request Oct 2, 2019
@bors
Auto merge of#65009- Centril:rollup-06g05xj, r=Centril
2daa404
Rollup of 13 pull requests
Successful merges:
- #64581 (Fix unreachable_code warnings for try{} block ok-wrapped expressions)
- #64850 (Remove inlines from DepNode code)
- #64914 (regression test for 64453 borrow check error.)
- #64922 (Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions)
- #64948 (Improve sidebar styling to make its integration easier)
- #64961 (Make comment about dummy type a bit more clear)
- #64967 (Don't mark borrows of zero-sized arrays as indirectly mutable)
- #64973 (Fix typo while setting `compile-flags` in test)
- #64980 (Enable support for `IndirectlyMutableLocals` in `rustc_peek` )
- #64989 (Fix ICE #64964)
- #64991 ([const-prop] Correctly handle locals that can't be propagated)
- #64995 (Remove rustdoc warning)
- #64997 (rustc book: nitpick SLP vectorization)
Failed merges:
r? @ghost
@bors
bors merged commit 79dc862 into rust-lang:masterOct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes
@oli-obkoli-obkoli-obk approved these changes

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@spastorino@rust-timer@bors@oli-obk@mati865@Centril@nikomatsakis@rust-highfive