Uh oh!
There was an error while loading. Please reload this page.
Fix typo while setting compile-flags in test - #64973
Merged
Merged
Conversation
rust-highfive
commented
Oct 1, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
rustc in testcompile-flags in testalexcrichton
commented
Oct 2, 2019
Member
@bors: r+ rollup |
bors
commented
Oct 2, 2019
Collaborator
📌 Commit cf984d2 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 2, 2019
…r=alexcrichton Fix typo while setting `compile-flags` in test This test is meant to check for an ICE when generating debug info, but didn't actually pass `-g` due to the typo. I also removed the `FIXME`, since this needs to actually be built (not just checked) to trigger the ICE.
bors added a commit
that referenced
this pull request
Oct 2, 2019
Rollup of 13 pull requests Successful merges: - #64581 (Fix unreachable_code warnings for try{} block ok-wrapped expressions) - #64850 (Remove inlines from DepNode code) - #64914 (regression test for 64453 borrow check error.) - #64922 (Use PlaceBuilder to avoid a lot of slice -> vec -> slice convertions) - #64948 (Improve sidebar styling to make its integration easier) - #64961 (Make comment about dummy type a bit more clear) - #64967 (Don't mark borrows of zero-sized arrays as indirectly mutable) - #64973 (Fix typo while setting `compile-flags` in test) - #64980 (Enable support for `IndirectlyMutableLocals` in `rustc_peek` ) - #64989 (Fix ICE #64964) - #64991 ([const-prop] Correctly handle locals that can't be propagated) - #64995 (Remove rustdoc warning) - #64997 (rustc book: nitpick SLP vectorization) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is meant to check for an ICE when generating debug info, but didn't actually pass
-gdue to the typo.I also removed the
FIXME, since this needs to actually be built (not just checked) to trigger the ICE.