Uh oh!
There was an error while loading. Please reload this page.
Reword E0392 slightly - #64931
Merged
Merged
Conversation
Make it clearer that a type or lifetime argument not being used can be fixed by referencing it in a struct's fields, not just using `PhathomData`.
rust-highfive
commented
Sep 30, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Centril
reviewed
Oct 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
matthewjasper
commented
Oct 2, 2019
Contributor
r=me with Centril's comment addressed |
Centril
commented
Oct 2, 2019
Contributor
Seems like some submodules were accidentally updated? |
estebankforce-pushed
the
missing-param-ref
branch
from
October 2, 2019 21:34
0ed41de to
a180294Compareestebank
commented
Oct 2, 2019
ContributorAuthor
@Centril sigh, cleaned up |
Centril
commented
Oct 2, 2019
Contributor
@bors r=matthewjasper,Centril rollup |
bors
commented
Oct 2, 2019
Collaborator
📌 Commit a180294 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 2, 2019
…ewjasper,Centril Reword E0392 slightly Make it clearer that a type or lifetime argument not being used can be fixed by referencing it in a struct's fields, not just using `PhathomData`. CC rust-lang#53589.
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 3, 2019
…ewjasper,Centril Reword E0392 slightly Make it clearer that a type or lifetime argument not being used can be fixed by referencing it in a struct's fields, not just using `PhathomData`. CC rust-lang#53589.
bors added a commit
that referenced
this pull request
Oct 3, 2019
Rollup of 7 pull requests Successful merges: - #63678 (Improve HRTB error span when -Zno-leak-check is used) - #64931 (Reword E0392 slightly) - #64959 (syntax: improve parameter without type suggestions) - #64975 (Implement Clone::clone_from for LinkedList) - #64993 (BacktraceStatus: add Eq impl) - #64998 (Filter out RLS output directories on tidy runs) - #65010 (Compare `primary` with maximum of `children`s' line num instead of dropping it) Failed merges: r? @ghost
mathstuf
reviewed
Oct 3, 2019
| } | ||
| let msg = if let Some(def_id) = suggested_marker_id { | ||
| format!( | ||
| "consider removing `{}`, refering to it in a field, or using a marker such as `{}`", |
Contributor
There was a problem hiding this comment.
It should yes, but let's fix it in a follow-up (pending rollup...)
mathstuf added a commit
to mathstuf/rust
that referenced
this pull request
Oct 3, 2019
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 3, 2019
typo: fix typo in E0392 See rust-lang#64931. --- Cc: @Centril@estebank
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 3, 2019
typo: fix typo in E0392 See rust-lang#64931. --- Cc: @Centril@estebank
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Oct 3, 2019
typo: fix typo in E0392 See rust-lang#64931. --- Cc: @Centril@estebank
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Oct 3, 2019
typo: fix typo in E0392 See rust-lang#64931. --- Cc: @Centril@estebank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clearer that a type or lifetime argument not being used can be
fixed by referencing it in a struct's fields, not just using
PhathomData.CC #53589.