Uh oh!
There was an error while loading. Please reload this page.
BacktraceStatus: add Eq impl - #64993
Merged
Merged
Conversation
See discussion on rust-lang#53487.
rust-highfive
commented
Oct 2, 2019
Contributor
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
withoutboats
commented
Oct 2, 2019
Contributor
@bors r+ Not sure about Copy. Can't imagine a reason not to have it, but who knows. Let's leave it as is for now? |
bors
commented
Oct 2, 2019
Collaborator
📌 Commit fb80e6c has been approved by |
Centril
commented
Oct 2, 2019
Contributor
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 2, 2019
…houtboats BacktraceStatus: add Eq impl See discussion on rust-lang#53487. --- Is adding `Copy` too ambitious? It's a "status", so I don't forsee any non-POD data that might go in there, but it would restrict future variants more than `Eq` does. Cc: @withoutboats@abonander
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 2, 2019
…houtboats BacktraceStatus: add Eq impl See discussion on rust-lang#53487. --- Is adding `Copy` too ambitious? It's a "status", so I don't forsee any non-POD data that might go in there, but it would restrict future variants more than `Eq` does. Cc: @withoutboats@abonander
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 3, 2019
…houtboats BacktraceStatus: add Eq impl See discussion on rust-lang#53487. --- Is adding `Copy` too ambitious? It's a "status", so I don't forsee any non-POD data that might go in there, but it would restrict future variants more than `Eq` does. Cc: @withoutboats@abonander
bors added a commit
that referenced
this pull request
Oct 3, 2019
Rollup of 7 pull requests Successful merges: - #63678 (Improve HRTB error span when -Zno-leak-check is used) - #64931 (Reword E0392 slightly) - #64959 (syntax: improve parameter without type suggestions) - #64975 (Implement Clone::clone_from for LinkedList) - #64993 (BacktraceStatus: add Eq impl) - #64998 (Filter out RLS output directories on tidy runs) - #65010 (Compare `primary` with maximum of `children`s' line num instead of dropping it) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion on #53487.
Is adding
Copytoo ambitious? It's a "status", so I don't forsee any non-POD data that might go in there, but it would restrict future variants more thanEqdoes.Cc: @withoutboats@abonander