Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #65299
Closed
tmandry wants to merge 68 commits into
Closed
Conversation
It was unclear what the implementation does when it encounters existing keys. This change makes it clear by documenting the trait impl.
This example failed to compile because of implicit `Sized` bound for `A` parameter that wasn't required by `Trait`.
function pointer const parameters.
const_compare_raw_pointers.
Co-Authored-By: varkor <github@varkor.com>
…locks and table lookups on each access of crate metadata.
libstd: Fix typos in doc
…varkor Function pointers as const generic arguments Makes function pointers as const generic arguments usable. Fixesrust-lang#62395 r? @varkor
Added doc about behavior of extend on HashMap It was unclear what the implementation does when it encounters existing keys. This change makes it clear by documenting the trait impl.
…=nikomatsakis Add some regression tests - Add a test for rust-lang#62187. - Clean up the directory structure in `src/test/ui/const-generics` - Closesrust-lang#64792. - Closesrust-lang#57399. - Closesrust-lang#57271.
Add ?Sized bound to a supertrait listing in E0038 error documentation This example failed to compile because of implicit `Sized` bound for `A` parameter that wasn't required by `Trait`.
…-E0568, r=estebank Add long error explanation for E0568 Part of rust-lang#61137.
…tril
Deduplicate is_{freeze,copy,sized}_raw
Addresses rust-lang#65259
Deduplicates `is_{freeze,copy,sized}_raw` by delegating to a new method which takes in a `LangItem`.Mark Path::join as must_use I've accidentally did `mut_path_buf.jon(a_path);`, expecting this to be an in-place modification. Seems like we can easily warn in such cases?
…mulacrum Don't cc rust-lang/compiler for toolstate changes Fixesrust-lang#65238.
Query generator kind for error reporting Fixesrust-lang#65166 (comment) r? @estebank cc @cramertj
stability: Do not use `buffer_lint` after lowering to HIR Fixesrust-lang#65253
Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost
tmandry
commented
Oct 11, 2019
MemberAuthor
@bors r+ p=12 rollup=never |
bors
commented
Oct 11, 2019
Collaborator
📌 Commit c7c6cbf has been approved by |
bors
commented
Oct 11, 2019
Collaborator
⌛ Testing commit c7c6cbf with merge eb924f1b9efdb84d89eae42eb2e76f4497982125... |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 11, 2019
Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost
Centril
commented
Oct 11, 2019
Contributor
Seems the 16 PR rollup was included as well? @bors r- retry |
bors added a commit
that referenced
this pull request
Oct 11, 2019
Rollup of 11 pull requests Successful merges: - #64337 (libstd: Fix typos in doc) - #65048 (Added doc about behavior of extend on HashMap) - #65191 (Add some regression tests) - #65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - #65205 (Add long error explanation for E0568) - #65263 (Deduplicate is_{freeze,copy,sized}_raw) - #65266 (Mark Path::join as must_use) - #65276 (Don't cc rust-lang/compiler for toolstate changes) - #65277 (Query generator kind for error reporting) - #65283 (stability: Do not use `buffer_lint` after lowering to HIR) - #65299 (Rollup of 16 pull requests) Failed merges: r? @ghost
tmandry
commented
Oct 11, 2019
MemberAuthor
😞 not sure how that happened.. |
Contributor
@tmandry probably a bug in homu introduced by yours truly... and which @pietroalbini reverted. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
buffer_lintafter lowering to HIR #65283 (stability: Do not usebuffer_lintafter lowering to HIR)Failed merges:
r? @ghost