Cleanup librustc mir err codes by GuillaumeGomez · Pull Request #65265 · rust-lang/rust

GuillaumeGomez · 2019-10-10T08:57:19Z

Three things are done in this PR:

Sort error codes
Uncomment an error code long error explanation (they should never be commented)
Unify explanations

rust-highfive · 2019-10-10T08:57:22Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2019-10-10T08:57:23Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2019-10-10T13:20:05Z

Can you give rational for sorting the error codes? To be frank, it just seems like an excellent way to cause merge conflicts and is otherwise useless - unless I'm missing something. If we had only a couple error codes it might make more sense but I usually can't fit a single error code explanation on screen at a time, much less see two at once to know that they're sorted.

GuillaumeGomez · 2019-10-10T13:54:46Z

Doesn't have much interest in itself. It's just more "clean". However, if you go through missing error codes like I'm currently doing, it helps a lot because generally the error codes close to the one you're writing have pretty close examples that you can use. All depending on the point of view. :)

Mark-Simulacrum · 2019-10-10T15:27:14Z

r=me with the box syntax removed

GuillaumeGomez · 2019-10-10T15:39:36Z

I couldn't find out how to get the error without the box syntax (which is very strange).

Mark-Simulacrum · 2019-10-10T16:02:11Z

I guess you can technically get it via vec![10] because that uses box internally, and I'd probably prefer that (it also generates other error codes though). We just don't have any allocating const fn functions to fall back on which is required to get this error, since we don't support it :)

GuillaumeGomez · 2019-10-10T22:16:38Z

Nicely found! Thanks a lot for the tip!

@bors: r=Mark-Simulacrum

bors · 2019-10-10T22:16:39Z

📌 Commit 06a02b5 has been approved by Mark-Simulacrum

…-err-codes, r=Mark-Simulacrum Cleanup librustc mir err codes Three things are done in this PR: * Sort error codes * Uncomment an error code long error explanation (they should **never** be commented) * Unify explanations

@ghost

Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost

@ghost

Rollup of 16 pull requests Successful merges: - rust-lang#64337 (libstd: Fix typos in doc) - rust-lang#64986 (Function pointers as const generic arguments) - rust-lang#65048 (Added doc about behavior of extend on HashMap) - rust-lang#65191 (Add some regression tests) - rust-lang#65200 (Add ?Sized bound to a supertrait listing in E0038 error documentation) - rust-lang#65205 (Add long error explanation for E0568) - rust-lang#65240 (self-profiling: Add events for metadata loading (plus a small dep-tracking optimization)) - rust-lang#65248 (Suggest `if let` on `let` refutable binding) - rust-lang#65252 (expand: Simplify expansion of derives) - rust-lang#65263 (Deduplicate is_{freeze,copy,sized}_raw) - rust-lang#65265 (Cleanup librustc mir err codes) - rust-lang#65266 (Mark Path::join as must_use) - rust-lang#65276 (Don't cc rust-lang/compiler for toolstate changes) - rust-lang#65277 (Query generator kind for error reporting) - rust-lang#65283 (stability: Do not use `buffer_lint` after lowering to HIR) - rust-lang#65289 (Fix suggested bound addition diagnostic) Failed merges: r? @ghost

…-err-codes, r=Mark-Simulacrum Cleanup librustc mir err codes Three things are done in this PR: * Sort error codes * Uncomment an error code long error explanation (they should **never** be commented) * Unify explanations

Centril · 2019-10-14T05:51:33Z

This seems to reproduce diffs under --compare-mode=nll -- please check that it doesn't or --bless otherwise. @bors r-

GuillaumeGomez · 2019-10-15T11:54:55Z

Re-ran the tests so let's r+ it again.

@bors: r=Mark-Simulacrum

bors · 2019-10-15T11:54:56Z

📌 Commit d4e3e6b has been approved by Mark-Simulacrum

…-err-codes, r=Mark-Simulacrum Cleanup librustc mir err codes Three things are done in this PR: * Sort error codes * Uncomment an error code long error explanation (they should **never** be commented) * Unify explanations

@ghost

Rollup of 14 pull requests Successful merges: - #64603 (Reducing spurious unused lifetime warnings.) - #64623 (Remove last uses of gensyms) - #65235 (don't assume we can *always* find a return type hint in async fn) - #65242 (Fix suggestion to constrain trait for method to be found) - #65265 (Cleanup librustc mir err codes) - #65293 (Optimize `try_expand_impl_trait_type`) - #65307 (Try fix incorrect "explicit lifetime name needed") - #65308 (Add long error explanation for E0574) - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members) - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.) - #65402 (Add troubleshooting section to PGO chapter in rustc book.) - #65425 (Optimize `BitIter`) - #65438 (Organize `never_type` tests) - #65444 (Implement AsRef<[T]> for List<T>) Failed merges: - #65390 (Add long error explanation for E0576) r? @ghost

rust-highfive assigned varkor Oct 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2019

varkor assigned Mark-Simulacrum and unassigned varkor Oct 10, 2019

GuillaumeGomez force-pushed the cleanup-librustc_mir-err-codes branch from 993d3df to 06a02b5Compare October 10, 2019 22:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2019

tmandry mentioned this pull request Oct 11, 2019
Rollup of 16 pull requests #65297
Closed

Centril mentioned this pull request Oct 14, 2019
Rollup of 8 pull requests #65396
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2019

GuillaumeGomez added 4 commits October 14, 2019 11:06

Sort long error code explanation by error code
307a356

Uncomment E0386 to let users have access to its old definition
c6de3eb

Unification and cleanup of librustc_mir error codes
6545819

Delete extra file
d4e3e6b

GuillaumeGomez force-pushed the cleanup-librustc_mir-err-codes branch from 06a02b5 to d4e3e6bCompare October 14, 2019 11:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2019

tmandry mentioned this pull request Oct 15, 2019
Rollup of 14 pull requests #65454
Merged

bors merged commit d4e3e6b into rust-lang:masterOct 16, 2019

GuillaumeGomez deleted the cleanup-librustc_mir-err-codes branch October 16, 2019 08:21

Navigation Menu

Uh oh!

Uh oh!

Cleanup librustc mir err codes - #65265

Cleanup librustc mir err codes#65265
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:cleanup-librustc_mir-err-codes

GuillaumeGomez commented Oct 10, 2019

Uh oh!

rust-highfive commented Oct 10, 2019

Uh oh!

rust-highfive commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

bors commented Oct 10, 2019

Uh oh!

Centril commented Oct 14, 2019

Uh oh!

GuillaumeGomez commented Oct 15, 2019

Uh oh!

bors commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Oct 10, 2019

Uh oh!

rust-highfive commented Oct 10, 2019

Uh oh!

rust-highfive commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

Mark-Simulacrum commented Oct 10, 2019

Uh oh!

GuillaumeGomez commented Oct 10, 2019

Uh oh!

bors commented Oct 10, 2019

Uh oh!

Centril commented Oct 14, 2019

Uh oh!

GuillaumeGomez commented Oct 15, 2019

Uh oh!

bors commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants