Uh oh!
There was an error while loading. Please reload this page.
Move Nonterminal::to_tokenstream to parser & don't rely directly on parser in lowering - #65392
Merged
Conversation
Centril
commented
Oct 13, 2019
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Oct 13, 2019
Member
@bors r+ Seems like a pretty clean split, though I'd want to be cautious about adding more such ptrs; I think if we need more then we'll want something like |
bors
commented
Oct 13, 2019
Collaborator
📌 Commit 07e946c has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 14, 2019
Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering Split out from rust-lang#65324. r? @petrochenkov
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 14, 2019
Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering Split out from rust-lang#65324. r? @petrochenkov
bors added a commit
that referenced
this pull request
Oct 14, 2019
Rollup of 7 pull requests Successful merges: - #65215 (Add long error explanation for E0697) - #65292 (Print lifetimes with backticks) - #65362 (syntax: consolidate function parsing in item.rs) - #65363 (Remove implicit dependencies on syntax::pprust) - #65379 (refactor session::config::build_session_options_and_crate_config) - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering) - #65395 (Add some tests for fixed ICEs) Failed merges: r? @ghost
bors added a commit
that referenced
this pull request
Oct 14, 2019
Rollup of 7 pull requests Successful merges: - #65215 (Add long error explanation for E0697) - #65292 (Print lifetimes with backticks) - #65362 (syntax: consolidate function parsing in item.rs) - #65363 (Remove implicit dependencies on syntax::pprust) - #65379 (refactor session::config::build_session_options_and_crate_config) - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering) - #65395 (Add some tests for fixed ICEs) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #65324.
r? @petrochenkov