Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #65396
Closed
Centril wants to merge 27 commits into
Closed
Conversation
Instead just use `pprust::path_to_string(..)` where needed. This has two benefits: a) The AST definition is now independent of printing it. (Therefore we get closer to extracting a data-crate.) b) Debugging should be easier as program flow is clearer.
…=GuillaumeGomez Add long error explanation for E0697 Part of rust-lang#61137 r? @GuillaumeGomez
…-err-codes, r=Mark-Simulacrum Cleanup librustc mir err codes Three things are done in this PR: * Sort error codes * Uncomment an error code long error explanation (they should **never** be commented) * Unify explanations
…entril Print lifetimes with backticks Fixesrust-lang#65287 r? @varkor
syntax: consolidate function parsing in item.rs Extracted from rust-lang#65324. r? @estebank
Remove implicit dependencies on syntax::pprust Part of rust-lang#65324. The main goal here is to facilitate the eventual move of pprust out from libsyntax and because an AST definition typically should not depend on its pretty printer. r? @estebank
…ochenkov refactor session::config::build_session_options_and_crate_config I'm not exactly sure what happened in rust-lang#65361 (comment) so in an effort to bisect the error I'm extracting out the first commit so it can hopefully land (I suspect the error is in the 2nd-3rd commits.) r? @petrochenkov (I'll r=you when the PR builder is happy)
Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering Split out from rust-lang#65324. r? @petrochenkov
Add some tests for fixed ICEs Fixesrust-lang#44153 (from 1.23.0) Fixesrust-lang#47486 (from 1.36.0) Fixesrust-lang#48010 (from 1.38.0) Fixesrust-lang#48027 (from nightly) Fixesrust-lang#48638 (from nightly)
Centril
commented
Oct 14, 2019
ContributorAuthor
@bors r+ p=8 rollup=never |
bors
commented
Oct 14, 2019
Collaborator
📌 Commit 045339c has been approved by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Nonterminal::to_tokenstreamto parser & don't rely directly on parser in lowering #65392 (MoveNonterminal::to_tokenstreamto parser & don't rely directly on parser in lowering)Failed merges:
r? @ghost