Speed up `LexicalResolve::expansion()` by nnethercote · Pull Request #65480 · rust-lang/rust

nnethercote · 2019-10-16T22:38:37Z

A couple of improvements that speed up unicode_normalization by about 4%. The first commit was enabled by the improvements to BitSet iteration in #65425.

r? @nikomatsakis

This wins 3% on `unicode_normalization`.

The commit also removes the debug statement, because they annoyed me. This change wins another 1% on `unicode_normalization`, at least partly because it no longer needs to increment `iteration`.

nnethercote · 2019-10-16T22:41:03Z

@bors try @rust-timer queue

rust-timer · 2019-10-16T22:41:04Z

Awaiting bors try build completion

bors · 2019-10-16T22:41:13Z

⌛ Trying commit d51fee0 with merge e320fe5...

@nikomatsakis

Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in #65425. r? @nikomatsakis

bors · 2019-10-17T01:47:53Z

☀️ Try build successful - checks-azure
Build commit: e320fe5 (e320fe5a2960de892c68a3a8ae505cec846d53e6)

rust-timer · 2019-10-17T01:47:54Z

Queued e320fe5 with parent 0e8a4b4, future comparison URL.

rust-timer · 2019-10-17T10:35:08Z

Finished benchmarking try commit e320fe5, comparison URL.

nnethercote · 2019-10-17T11:00:37Z

5-7% wins on unicode_normalizationon CI, which is more than what I saw locally. I'll take it!

nikomatsakis · 2019-10-17T22:24:24Z

@bors r+

bors · 2019-10-17T22:24:25Z

📌 Commit d51fee0 has been approved by nikomatsakis

@nikomatsakis

…size, r=nikomatsakis Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425. r? @nikomatsakis

@nikomatsakis

…size, r=nikomatsakis Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425. r? @nikomatsakis

@nikomatsakis

…size, r=nikomatsakis Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425. r? @nikomatsakis

@ghost

Rollup of 17 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65417 (Add more coherence tests) - #65434 (Add long error explanation for E0577) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65496 (properly document panics in div_euclid and rem_euclid) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65471 (Add long error explanation for E0578) r? @ghost

@nikomatsakis

…size, r=nikomatsakis Speed up `LexicalResolve::expansion()` A couple of improvements that speed up `unicode_normalization` by about 4%. The first commit was enabled by the improvements to `BitSet` iteration in rust-lang#65425. r? @nikomatsakis

@ghost

Rollup of 19 pull requests Successful merges: - #65016 (Always inline `mem::{size_of,align_of}` in debug builds) - #65197 (Prepare `MutVisitor`s to handle interned projections) - #65201 (Disable Go and OCaml bindings when building LLVM) - #65334 (Add long error explanation for E0575) - #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic) - #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions) - #65472 (Use a sharded dep node to dep node index map) - #65480 (Speed up `LexicalResolve::expansion()`) - #65493 (Add long error explanation for E0584) - #65496 (properly document panics in div_euclid and rem_euclid) - #65498 (Plugins deprecation: don’t suggest simply removing the attribute) - #65508 (add option to ping llvm ice-breakers to triagebot) - #65511 (save-analysis: Nest tables when processing impl block definitions) - #65513 (reorder fmt docs for more clarity) - #65532 (doc: make BitSet intro more short) - #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.) - #65540 (show up some extra info when t!() fails) - #65549 (Fix left/right shift typo in wrapping rotate docs) - #65552 (Clarify diagnostics when using `~` as a unary op) Failed merges: - #65390 (Add long error explanation for E0576) - #65434 (Add long error explanation for E0577) - #65471 (Add long error explanation for E0578) r? @ghost

nnethercote added 2 commits October 17, 2019 06:58

Use a BitSet in LexicalResolver::iterate_until_fixed_point().
70b136d
This wins 3% on `unicode_normalization`.

Inline and remove iterate_until_fixed_point().
d51fee0
The commit also removes the debug statement, because they annoyed me. This change wins another 1% on `unicode_normalization`, at least partly because it no longer needs to increment `iteration`.

rust-highfive assigned nikomatsakis Oct 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2019

nikomatsakis approved these changes Oct 17, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019

tmandry mentioned this pull request Oct 18, 2019
Rollup of 13 pull requests #65548
Closed

tmandry mentioned this pull request Oct 18, 2019
Rollup of 12 pull requests #65550
Closed

tmandry mentioned this pull request Oct 18, 2019
Rollup of 17 pull requests #65565
Closed

tmandry mentioned this pull request Oct 18, 2019
Rollup of 19 pull requests #65570
Merged

bors merged commit d51fee0 into rust-lang:masterOct 19, 2019

nnethercote mentioned this pull request Oct 19, 2019
Long compilation time of crate "unicode-normalization" #55528
Closed

nnethercote deleted the rm-iterate_until_fixed_size branch October 19, 2019 23:27

Navigation Menu

Uh oh!

Uh oh!

Speed up `LexicalResolve::expansion()` - #65480

Speed up `LexicalResolve::expansion()`#65480
bors merged 2 commits into
rust-lang:masterfrom
nnethercote:rm-iterate_until_fixed_size

nnethercote commented Oct 16, 2019

Uh oh!

nnethercote commented Oct 16, 2019

Uh oh!

rust-timer commented Oct 16, 2019

Uh oh!

bors commented Oct 16, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

rust-timer commented Oct 17, 2019

Uh oh!

rust-timer commented Oct 17, 2019

Uh oh!

nnethercote commented Oct 17, 2019

Uh oh!

nikomatsakis commented Oct 17, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

nnethercote commented Oct 16, 2019

Uh oh!

nnethercote commented Oct 16, 2019

Uh oh!

rust-timer commented Oct 16, 2019

Uh oh!

bors commented Oct 16, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

rust-timer commented Oct 17, 2019

Uh oh!

rust-timer commented Oct 17, 2019

Uh oh!

nnethercote commented Oct 17, 2019

Uh oh!

nikomatsakis commented Oct 17, 2019

Uh oh!

bors commented Oct 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants