Skip to content

add option to ping llvm ice-breakers to triagebot - #65508

Merged
bors merged 2 commits into
masterfrom
llvm-icebreakers-ping-1
Oct 19, 2019
Merged

add option to ping llvm ice-breakers to triagebot#65508
bors merged 2 commits into
masterfrom
llvm-icebreakers-ping-1

Conversation

@nikomatsakis

Copy link
Copy Markdown
Contributor

No description provided.

@nikomatsakis

Copy link
Copy Markdown
ContributorAuthor

r? @Mark-Simulacrum

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2019

@Mark-SimulacrumMark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with this nit applied

Comment threadtriagebot.toml Outdated
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@nikomatsakis

Copy link
Copy Markdown
ContributorAuthor

@bors r+

@bors

bors commented Oct 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5487994 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2019
@nikomatsakis

Copy link
Copy Markdown
ContributorAuthor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2019
@nikomatsakis

Copy link
Copy Markdown
ContributorAuthor

@bors r=simulacrum

@bors

bors commented Oct 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5487994 has been approved by simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 17, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@CentrilCentril mentioned this pull request Oct 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@CentrilCentril mentioned this pull request Oct 18, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@tmandrytmandry mentioned this pull request Oct 18, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@tmandrytmandry mentioned this pull request Oct 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@CentrilCentril mentioned this pull request Oct 18, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@tmandrytmandry mentioned this pull request Oct 18, 2019
bors added a commit that referenced this pull request Oct 18, 2019
Rollup of 17 pull requests
Successful merges:
- #65016 (Always inline `mem::{size_of,align_of}` in debug builds)
- #65197 (Prepare `MutVisitor`s to handle interned projections)
- #65201 (Disable Go and OCaml bindings when building LLVM)
- #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic)
- #65417 (Add more coherence tests)
- #65434 (Add long error explanation for E0577)
- #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
- #65472 (Use a sharded dep node to dep node index map)
- #65480 (Speed up `LexicalResolve::expansion()`)
- #65496 (properly document panics in div_euclid and rem_euclid)
- #65508 (add option to ping llvm ice-breakers to triagebot)
- #65511 (save-analysis: Nest tables when processing impl block definitions)
- #65513 (reorder fmt docs for more clarity)
- #65532 (doc: make BitSet intro more short)
- #65540 (show up some extra info when t!() fails)
- #65549 (Fix left/right shift typo in wrapping rotate docs)
- #65552 (Clarify diagnostics when using `~` as a unary op)
Failed merges:
- #65471 (Add long error explanation for E0578)
r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Oct 18, 2019
…r=simulacrum
add option to ping llvm ice-breakers to triagebot
@tmandrytmandry mentioned this pull request Oct 18, 2019
bors added a commit that referenced this pull request Oct 19, 2019
Rollup of 19 pull requests
Successful merges:
- #65016 (Always inline `mem::{size_of,align_of}` in debug builds)
- #65197 (Prepare `MutVisitor`s to handle interned projections)
- #65201 (Disable Go and OCaml bindings when building LLVM)
- #65334 (Add long error explanation for E0575)
- #65364 (Collect occurrences of empty blocks for mismatched braces diagnostic)
- #65455 (Avoid unnecessary `TokenTree` to `TokenStream` conversions)
- #65472 (Use a sharded dep node to dep node index map)
- #65480 (Speed up `LexicalResolve::expansion()`)
- #65493 (Add long error explanation for E0584)
- #65496 (properly document panics in div_euclid and rem_euclid)
- #65498 (Plugins deprecation: don’t suggest simply removing the attribute)
- #65508 (add option to ping llvm ice-breakers to triagebot)
- #65511 (save-analysis: Nest tables when processing impl block definitions)
- #65513 (reorder fmt docs for more clarity)
- #65532 (doc: make BitSet intro more short)
- #65535 (rustc: arena-allocate the slice in `ty::GenericsPredicate`, not the whole struct.)
- #65540 (show up some extra info when t!() fails)
- #65549 (Fix left/right shift typo in wrapping rotate docs)
- #65552 (Clarify diagnostics when using `~` as a unary op)
Failed merges:
- #65390 (Add long error explanation for E0576)
- #65434 (Add long error explanation for E0577)
- #65471 (Add long error explanation for E0578)
r? @ghost
@bors
bors merged commit 5487994 into masterOct 19, 2019
@dtolnay
dtolnay deleted the llvm-icebreakers-ping-1 branch October 27, 2019 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nikomatsakis@rust-highfive@bors@Mark-Simulacrum@alexcrichton