Update Source Code Pro and include italics by tspiteri · Pull Request #65665 · rust-lang/rust

tspiteri · 2019-10-21T14:41:20Z

A few notes:

As stated in Rustdoc uses fake italics for code #65502, this does increase the download size.
Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged.
The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files (Source Code Pro otf renders poorly on older Windows system apps).

hellow554 · 2019-10-22T06:32:59Z

As stated in #65502, this does increase the download size.

Can you say how much it will increase?

tspiteri · 2019-10-22T07:01:30Z

Reproducing the table in the issue below. Updating the upright fonts to the latest version costs an extra 79 KiB, and including the italics costs 82 KiB, total increase is 161 KiB. I believe this shouldn't be such an issue, especially with caching.

Font	Current Size	Latest Size
Regular	55472	95872
Semibold	55360	95576
Italic		84264
Total	110832	275712

tspiteri · 2019-10-26T11:01:00Z

@JohnCSimon I think you got the wrong label.

JohnCSimon · 2019-11-09T06:44:15Z

Ping from triage
@QuietMisdreavus can you please review this pr?
cc: @tspiteri
Thanks

Dylan-DPC-zz · 2019-11-11T22:53:47Z

r? @GuillaumeGomez

GuillaumeGomez · 2019-11-12T22:44:30Z

So we're doubling the size of the font to add italic if I understood correctly?

tspiteri · 2019-11-13T07:32:31Z

Basically adding about 75% current size to add italic, and this PR also adds another 75% to update the upright and bold to the latest version, so it's a 150% increase in total (from 110 kb to 275 kb).

GuillaumeGomez · 2019-11-13T14:12:38Z

I'm not sure if it's worth it... Any additional opinion @rust-lang/rustdoc ?

joelpalmer · 2019-11-18T11:43:24Z

Ping from Triage: Any updates @rust-lang/rustdoc @GuillaumeGomez @tspiteri?

ollie27 · 2019-11-19T22:49:33Z

I think we should merge this. If we're going to ship custom fonts they should at least be up to date and complete.

GuillaumeGomez · 2019-11-20T10:30:40Z

Fine by me then. Thanks @tspiteri !

@bors: r+ rollup

bors · 2019-11-20T10:30:42Z

📌 Commit ea9519b has been approved by GuillaumeGomez

…dePro, r=GuillaumeGomez Update Source Code Pro and include italics Fixesrust-lang#65502. A few notes: * As stated in rust-lang#65502, this does increase the download size. * Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged. * The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files ([Source Code Pro otf renders poorly on older Windows system apps](adobe-fonts/source-code-pro#25 (comment))).

tspiteri · 2019-11-20T12:25:32Z

@GuillaumeGomez Great! When this is merged I think docs.rs has to be updated, though I couldn't figure out how that works in rust-lang/docs.rs#270.

@ghost

Rollup of 8 pull requests Successful merges: - #65665 (Update Source Code Pro and include italics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66497 (Fix#53820) - #66526 (Add more context to `async fn` trait error) - #66532 (Generate DWARF address ranges for faster lookups) - #66546 (Remove duplicate function) - #66548 ([RISCV] Disable Atomics on all Non-A RISC-V targets) - #66553 (remove HermitCore leftovers from sys/unix) Failed merges: r? @ghost

GuillaumeGomez · 2019-11-20T16:58:44Z

Don't worry, let them handle their part. ;)

cc @pietroalbini

ehuss · 2019-11-21T02:31:59Z

This broke font rendering on firefox on macos with the dark theme. See #60365 (comment) for details. Can we maybe have a different solution?

tspiteri · 2019-11-21T06:58:42Z

Aargh!

@GuillaumeGomez Should I open a PR to revert this PR?

GuillaumeGomez · 2019-11-21T10:16:49Z

Yes please.

GuillaumeGomez · 2019-11-21T10:20:21Z

Considering it's broken, I already open the PR to revert it here.

…dePro, r=GuillaumeGomez Update Source Code Pro and include italics Fixesrust-lang#65502. rust-lang#65665, a similar PR to this was merged but reverted because of rust-lang#65665 (comment). The issue in that comment is the upstream issue adobe-fonts/source-code-pro#217 which should now be fixed in the upstream since [2.032R-ro/1.052R-it/1.012R-VAR release](https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro/1.052R-it/1.012R-VAR), so I think this can now be merged. A couple of notes from the original PR: * Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged. * The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files (Source Code Pro otf renders poorly on older Windows system apps).

Update Source Code Pro and include italics
ea9519b

rust-highfive assigned QuietMisdreavus Oct 21, 2019

JohnCSimon added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 26, 2019

Dylan-DPC-zz added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2019

rust-highfive assigned GuillaumeGomez and unassigned QuietMisdreavus Nov 11, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2019

Centril mentioned this pull request Nov 20, 2019
Rollup of 8 pull requests #66571
Merged

bors merged commit ea9519b into rust-lang:masterNov 20, 2019

QuietMisdreavus mentioned this pull request Nov 20, 2019
add updated Source Code Pro to essential files rust-lang/docs.rs#481
Closed

tspiteri deleted the italic-and-update-SourceCodePro branch November 20, 2019 21:14

tspiteri restored the italic-and-update-SourceCodePro branch November 21, 2019 10:45

This comment has been minimized.
Sign in to view

tspiteri mentioned this pull request Apr 4, 2020
Rustdoc uses fake italics for code #65502
Closed

tspiteri mentioned this pull request Jan 4, 2021
Update Source Code Pro and include italics #80705
Merged

Uh oh!

Uh oh!

Conversation

tspiteri commented Oct 21, 2019

Uh oh!

hellow554 commented Oct 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tspiteri commented Oct 22, 2019

Uh oh!

tspiteri commented Oct 26, 2019

Uh oh!

JohnCSimon commented Nov 9, 2019

Uh oh!

Dylan-DPC-zz commented Nov 11, 2019

Uh oh!

GuillaumeGomez commented Nov 12, 2019

Uh oh!

tspiteri commented Nov 13, 2019

Uh oh!

GuillaumeGomez commented Nov 13, 2019

Uh oh!

joelpalmer commented Nov 18, 2019

Uh oh!

ollie27 commented Nov 19, 2019

Uh oh!

GuillaumeGomez commented Nov 20, 2019

Uh oh!

bors commented Nov 20, 2019

Uh oh!

tspiteri commented Nov 20, 2019

Uh oh!

GuillaumeGomez commented Nov 20, 2019

Uh oh!

ehuss commented Nov 21, 2019

Uh oh!

tspiteri commented Nov 21, 2019

Uh oh!

GuillaumeGomez commented Nov 21, 2019

Uh oh!

GuillaumeGomez commented Nov 21, 2019

Uh oh!

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

hellow554 commented Oct 22, 2019•
edited
Loading