Skip to content

Add more context to async fn trait error - #66526

Merged
bors merged 5 commits into
rust-lang:masterfrom
estebank:async-fn-trait-information
Nov 20, 2019
Merged

Add more context to async fn trait error#66526
bors merged 5 commits into
rust-lang:masterfrom
estebank:async-fn-trait-information

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Follow up to #65937. Fix#65899.

@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2019
@estebank

Copy link
Copy Markdown
ContributorAuthor

@gilescope, please take a look at the error code documentation.

@estebank
estebankforce-pushed the async-fn-trait-information branch from a41034f to 650f653CompareNovember 18, 2019 20:44
@estebank
estebankforce-pushed the async-fn-trait-information branch from 650f653 to e565329CompareNovember 18, 2019 23:23
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
Comment threadsrc/librustc_error_codes/error_codes/E0706.md Outdated
@Centril

Copy link
Copy Markdown
Contributor

r? @Centril

@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a079159 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
…, r=Centril
Add more context to `async fn` trait error
Follow up to rust-lang#65937. Fixrust-lang#65899.
@CentrilCentril mentioned this pull request Nov 20, 2019
bors added a commit that referenced this pull request Nov 20, 2019
Rollup of 8 pull requests
Successful merges:
- #65665 (Update Source Code Pro and include italics)
- #66478 (rustc_plugin: Remove the compatibility shim)
- #66497 (Fix#53820)
- #66526 (Add more context to `async fn` trait error)
- #66532 (Generate DWARF address ranges for faster lookups)
- #66546 (Remove duplicate function)
- #66548 ([RISCV] Disable Atomics on all Non-A RISC-V targets)
- #66553 (remove HermitCore leftovers from sys/unix)
Failed merges:
r? @ghost
@bors
bors merged commit a079159 into rust-lang:masterNov 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more context when trying to write async trait function

6 participants

@estebank@rust-highfive@Centril@bors@matthewjasper@Dylan-DPC