Skip to content

bring back some Debug instances for Miri - #65689

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:miri-debug
Oct 23, 2019
Merged

bring back some Debug instances for Miri#65689
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:miri-debug

Conversation

@RalfJung

Copy link
Copy Markdown
Member

These were erroneously removed in #65647, but Miri needs them.

r? @Centril Cc @nnethercote@oli-obk

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2019
@Centril

Copy link
Copy Markdown
Contributor

r=me with a comment added saying Miri needs them

@RalfJung

Copy link
Copy Markdown
MemberAuthor

Done.

@bors r=Centril rollup

@bors

bors commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit fc5b485 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
bring back some Debug instances for Miri
These were erroneously removed in rust-lang#65647, but Miri needs them.
r? @Centril Cc @nnethercote@oli-obk
@JohnTitorJohnTitor mentioned this pull request Oct 22, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
bring back some Debug instances for Miri
These were erroneously removed in rust-lang#65647, but Miri needs them.
r? @Centril Cc @nnethercote@oli-obk
@JohnTitorJohnTitor mentioned this pull request Oct 23, 2019
bors added a commit that referenced this pull request Oct 23, 2019
Rollup of 14 pull requests
Successful merges:
- #64145 (Target-feature documented as unsafe)
- #65007 (Mention keyword closing policy)
- #65417 (Add more coherence tests)
- #65507 (Fix test style in unused parentheses lint test)
- #65591 (Add long error explanation for E0588)
- #65617 (Fix WASI sleep impl)
- #65656 (Add option to disable keyboard shortcuts in docs)
- #65678 (Add long error explanation for E0728)
- #65681 (Code cleanups following up on #65576.)
- #65686 (refactor and move `maybe_append` )
- #65688 (Add some tests for fixed ICEs)
- #65689 (bring back some Debug instances for Miri)
- #65695 (self-profiling: Remove module names from some event-ids in codegen backend.)
- #65706 (Add missing space in librustdoc)
Failed merges:
r? @ghost
@bors
bors merged commit fc5b485 into rust-lang:masterOct 23, 2019
@RalfJung
RalfJung deleted the miri-debug branch October 23, 2019 18:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung@Centril@bors@rust-highfive