Uh oh!
There was an error while loading. Please reload this page.
rustc: use IndexVec<DefIndex, T> instead of Vec<T>. - #65825
Merged
Conversation
rust-highfive
commented
Oct 25, 2019
Contributor
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Oct 25, 2019
ContributorAuthor
@bors try @rust-timer queue |
rust-timer
commented
Oct 25, 2019
Collaborator
Awaiting bors try build completion |
bors
commented
Oct 25, 2019
Collaborator
⌛ Trying commit 70eb4bf6cd8eb56b8dfc22d767007b67a5979b24 with merge 76530884546a7aa7bf406b7af7e07c6225197ec0... |
bors
commented
Oct 25, 2019
Collaborator
☀️ Try build successful - checks-azure |
rust-timer
commented
Oct 25, 2019
Collaborator
Queued 76530884546a7aa7bf406b7af7e07c6225197ec0 with parent 23f890f, future comparison URL. |
rust-timer
commented
Oct 26, 2019
Collaborator
Finished benchmarking try commit 76530884546a7aa7bf406b7af7e07c6225197ec0, comparison URL. |
varkor
commented
Oct 26, 2019
Contributor
@bors r+ rollup |
bors
commented
Oct 26, 2019
Collaborator
📌 Commit 70eb4bf6cd8eb56b8dfc22d767007b67a5979b24 has been approved by |
bors added a commit
that referenced
this pull request
Oct 26, 2019
Rollup of 8 pull requests Successful merges: - #65743 (rustc_typeck: don't record direct callees in generator_interior.) - #65761 (libsyntax: Enhance documentation of the AST module) - #65772 (Remove the last remaining READMEs) - #65773 (Increase spacing for suggestions in diagnostics) - #65791 (Adding doc on keyword continue) - #65824 (rustc: make DefPathData (and friends) Copy (now that it uses Symbol).) - #65828 (Derive Eq and Hash for SourceInfo again) - #65842 (Add more information on rustdoc search) Failed merges: - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.) r? @ghost
This comment has been minimized.
This comment has been minimized.
eddyb
commented
Oct 28, 2019
ContributorAuthor
@bors r=varkor |
bors
commented
Oct 28, 2019
Collaborator
📌 Commit cc575a6 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 28, 2019
rustc: use IndexVec<DefIndex, T> instead of Vec<T>. Now that `DefIndex` is a proper index type, we can do that. There was also an unnecessary `Option` I removed, I wonder if that has perf implications.
Centril added a commit
to Centril/rust
that referenced
this pull request
Oct 28, 2019
rustc: use IndexVec<DefIndex, T> instead of Vec<T>. Now that `DefIndex` is a proper index type, we can do that. There was also an unnecessary `Option` I removed, I wonder if that has perf implications.
bors added a commit
that referenced
this pull request
Oct 28, 2019
Rollup of 9 pull requests Successful merges: - #65563 (Add long error explanation for E0587) - #65640 (Use heuristics to recover parsing of missing `;`) - #65643 (Correct handling of type flags with `ConstValue::Placeholder`) - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.) - #65858 (suggest `const_in_array_repeat_expression` flag) - #65877 (doc: introduce `once` in `iter::chain` document) - #65887 (doc: mention `get(_mut)` in Vec) - #65891 (self-profiling: Record something more useful for crate metadata generation event.) - #65893 (Output previous stable error messaging when using stable build.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
DefIndexis a proper index type, we can do that.There was also an unnecessary
OptionI removed, I wonder if that has perf implications.