Skip to content

doc: introduce once in iter::chain document - #65877

Merged
bors merged 1 commit into
rust-lang:masterfrom
tesuji:iter-chain-once
Oct 29, 2019
Merged

doc: introduce once in iter::chain document#65877
bors merged 1 commit into
rust-lang:masterfrom
tesuji:iter-chain-once

Conversation

@tesuji

Copy link
Copy Markdown
Contributor

I find it hard to find which one to use with chain when I only need to
chain one value. Also once talks about chain.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2019
Comment threadsrc/libcore/iter/traits/iterator.rs Outdated
@Centril

Copy link
Copy Markdown
Contributor

r? @Centril@bors rollup

r=me with comment addressed.

@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit b626448 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
doc: introduce `once` in `iter::chain` document
I find it hard to find which one to use with `chain` when I only need to
chain one value. Also [`once`][1] talks about `chain`.
[1]: https://doc.rust-lang.org/nightly/std/iter/fn.once.html
@CentrilCentril mentioned this pull request Oct 27, 2019
@tesuji
tesujiforce-pushed the iter-chain-once branch 2 times, most recently from cceee42 to eda2d47CompareOctober 28, 2019 03:17
@tesuji

Copy link
Copy Markdown
ContributorAuthor

The example compiles on godbolt: https://rust.godbolt.org/z/Edpz4b
Sorry for making the rollup failed.

@tesuji

Copy link
Copy Markdown
ContributorAuthor

Ping

@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9c4f60e has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Oct 28, 2019
doc: introduce `once` in `iter::chain` document
I find it hard to find which one to use with `chain` when I only need to
chain one value. Also [`once`][1] talks about `chain`.
[1]: https://doc.rust-lang.org/nightly/std/iter/fn.once.html
@CentrilCentril mentioned this pull request Oct 28, 2019
bors added a commit that referenced this pull request Oct 28, 2019
Rollup of 9 pull requests
Successful merges:
- #65563 (Add long error explanation for E0587)
- #65640 (Use heuristics to recover parsing of missing `;`)
- #65643 (Correct handling of type flags with `ConstValue::Placeholder`)
- #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.)
- #65858 (suggest `const_in_array_repeat_expression` flag)
- #65877 (doc: introduce `once` in `iter::chain` document)
- #65887 (doc: mention `get(_mut)` in Vec)
- #65891 (self-profiling: Record something more useful for crate metadata generation event.)
- #65893 (Output previous stable error messaging when using stable build.)
Failed merges:
r? @ghost
@bors
bors merged commit 9c4f60e into rust-lang:masterOct 29, 2019
@tesuji
tesuji deleted the iter-chain-once branch October 29, 2019 01:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tesuji@rust-highfive@Centril@bors@cramertj