Create E0744 error code for unterminated raw string error by GuillaumeGomez · Pull Request #66035 · rust-lang/rust

GuillaumeGomez · 2019-11-02T00:25:06Z

No description provided.

rust-highfive · 2019-11-02T00:25:09Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2019-11-02T00:25:10Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-11-02T02:06:14Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-02T00:25:42.0082531Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-02T00:25:42.0255141Z ##[command]git config gc.auto 0
2019-11-02T00:25:42.0324625Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-02T00:25:42.0378470Z ##[command]git config --get-all http.proxy
2019-11-02T00:25:42.0506923Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66035/merge:refs/remotes/pull/66035/merge
---
2019-11-02T01:20:01.9859577Z .................................................................................................... 1600/9265
2019-11-02T01:20:07.2791049Z .................................................................................................... 1700/9265
2019-11-02T01:20:18.8640598Z ............................................................i...............i....................... 1800/9265
2019-11-02T01:20:26.0713915Z .................................................................................................... 1900/9265
2019-11-02T01:20:39.4957135Z ..................................................iiiii............................................. 2000/9265
2019-11-02T01:20:49.2616784Z .................................................................................................... 2200/9265
2019-11-02T01:20:51.4871780Z .................................................................................................... 2300/9265
2019-11-02T01:20:54.6999831Z .................................................................................................... 2400/9265
2019-11-02T01:21:15.8988703Z .................................................................................................... 2500/9265
---
2019-11-02T01:23:51.7546626Z ..................................................i...............i................................. 4800/9265
2019-11-02T01:23:59.7587902Z .................................................................................................... 4900/9265
2019-11-02T01:24:07.7909418Z .................................................................................................... 5000/9265
2019-11-02T01:24:13.4024281Z .................................................................................................... 5100/9265
2019-11-02T01:24:22.8443041Z ...................................................ii.ii...........i................................ 5200/9265
2019-11-02T01:24:31.8525571Z .................................................................................................... 5400/9265
2019-11-02T01:24:41.1031925Z .................................................................................................... 5500/9265
2019-11-02T01:24:47.9978804Z ........................i........................................................................... 5600/9265
2019-11-02T01:24:53.9461167Z .................................................................................................... 5700/9265
2019-11-02T01:24:53.9461167Z .................................................................................................... 5700/9265
2019-11-02T01:25:04.6659494Z .................................................................................................... 5800/9265
2019-11-02T01:25:15.6361886Z .........ii...i..ii...........i..................................................................... 5900/9265
2019-11-02T01:25:35.4072290Z .................................................................................................... 6100/9265
2019-11-02T01:25:42.8799273Z .................................................................................................... 6200/9265
2019-11-02T01:25:42.8799273Z .................................................................................................... 6200/9265
2019-11-02T01:25:57.0875295Z ............................i..ii................................................................... 6300/9265
2019-11-02T01:26:15.6740348Z ..............................................................................................i..... 6500/9265
2019-11-02T01:26:17.6598253Z .................................................................................................... 6600/9265
2019-11-02T01:26:19.6497980Z .....................................................................i.............................. 6700/9265
2019-11-02T01:26:22.2649396Z .................................................................................................... 6800/9265
---
2019-11-02T01:31:12.4437389Z finished in 5.203
2019-11-02T01:31:12.4595278Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:31:12.6021441Z 2019-11-02T01:31:12.6021940Z running 158 tests
2019-11-02T01:31:15.3076466Z iiiiii....iii......iii..iiii...i.............................i..i..................i....i........... 100/158
2019-11-02T01:31:17.1364026Z ii.i.i..iiii..............i.........iii.i.........ii......
2019-11-02T01:31:17.1365295Z 2019-11-02T01:31:17.1369534Z finished in 4.677
2019-11-02T01:31:17.1545410Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:31:17.8448468Z ---
2019-11-02T01:31:19.1028666Z finished in 1.948
2019-11-02T01:31:19.1189609Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:31:19.2587884Z 2019-11-02T01:31:19.2588030Z running 9 tests
2019-11-02T01:31:19.2588638Z iiiiiiiii
2019-11-02T01:31:19.2590533Z 2019-11-02T01:31:19.2590569Z finished in 0.139
2019-11-02T01:31:19.2733168Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:31:20.3424897Z ---
2019-11-02T01:31:37.6096725Z finished in 18.336
2019-11-02T01:31:37.6300473Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:31:37.7767741Z 2019-11-02T01:31:37.7768533Z running 123 tests
2019-11-02T01:31:59.6765833Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-11-02T01:32:03.9344071Z i.i.i......iii.i.....ii
2019-11-02T01:32:03.9346234Z 2019-11-02T01:32:03.9347532Z finished in 26.304
2019-11-02T01:32:03.9356638Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:32:03.9357330Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-02T01:43:19.5717360Z 2019-11-02T01:43:19.5718776Z Doc-tests core
2019-11-02T01:43:24.1602146Z 2019-11-02T01:43:24.1609571Z running 2410 tests
2019-11-02T01:43:34.3890776Z ......iiiii......................................................................................... 100/2410
2019-11-02T01:43:44.5298924Z ................................................................................ii.................. 200/2410
2019-11-02T01:44:07.9662366Z ..i................................................................................................. 400/2410
2019-11-02T01:44:07.9662366Z ..i................................................................................................. 400/2410
2019-11-02T01:44:17.7805238Z ..................................................i..i.................iiii......................... 500/2410
2019-11-02T01:44:36.8588895Z .................................................................................................... 700/2410
2019-11-02T01:44:46.4702839Z .................................................................................................... 800/2410
2019-11-02T01:44:56.1962277Z .................................................................................................... 900/2410
2019-11-02T01:45:05.8291271Z .................................................................................................... 1000/2410
---
2019-11-02T01:48:57.9591040Z 2019-11-02T01:48:57.9592287Z running 999 tests
2019-11-02T01:49:17.6446186Z i................................................................................................... 100/999
2019-11-02T01:49:28.5252765Z .................................................................................................... 200/999
2019-11-02T01:49:36.4093549Z ...................iii......i......i...i......i..................................................... 300/999
2019-11-02T01:49:41.7667659Z .................................................................................................... 400/999
2019-11-02T01:49:48.9873777Z ..........................................i..i.................................ii................... 500/999
2019-11-02T01:50:02.6448788Z .................................................................................................... 700/999
2019-11-02T01:50:02.6448788Z .................................................................................................... 700/999
2019-11-02T01:50:09.8840074Z .........................iiii....................................................................... 800/999
2019-11-02T01:50:24.5446421Z .................................................................................................... 900/999
2019-11-02T01:50:31.8609759Z ...............................................iiii................................................
2019-11-02T01:50:31.8610031Z 2019-11-02T01:50:31.8733574Z finished in 180.487
2019-11-02T01:50:31.8748513Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-02T01:50:32.0618594Z Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-11-02T02:05:56.7624425Z Compiling error_index_generator v0.0.0 (/checkout/src/tools/error_index_generator)
2019-11-02T02:06:03.8997237Z Finished release [optimized] target(s) in 8.76s
2019-11-02T02:06:04.0056977Z 2019-11-02T02:06:04.0057209Z 2019-11-02T02:06:04.0058110Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/error_index_generator" "html" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc/error-index.html" "1.40.0"
2019-11-02T02:06:04.0058250Z 2019-11-02T02:06:04.0058278Z 2019-11-02T02:06:04.0064572Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-02T02:06:04.0064629Z Build completed unsuccessfully in 1:33:56
2019-11-02T02:06:04.0064629Z Build completed unsuccessfully in 1:33:56
2019-11-02T02:06:04.0117818Z == clock drift check ==
2019-11-02T02:06:04.0133398Z local time: Sat Nov 2 02:06:04 UTC 2019
2019-11-02T02:06:04.3105165Z network time: Sat, 02 Nov 2019 02:06:04 GMT
2019-11-02T02:06:04.3111143Z == end clock drift check ==
2019-11-02T02:06:09.6576091Z 2019-11-02T02:06:09.6680040Z ##[error]Bash exited with code '1'.
2019-11-02T02:06:09.6710644Z ##[section]Starting: Checkout
2019-11-02T02:06:09.6712204Z ==============================================================================
2019-11-02T02:06:09.6712244Z Task : Get sources
2019-11-02T02:06:09.6712295Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

GuillaumeGomez · 2019-11-02T14:09:28Z

I can't make it fail locally. Anyone has an idea about what's going on?

eddyb · 2019-11-02T21:50:55Z

r? @estebank

estebank · 2019-11-03T17:03:16Z

Suggested change
A raw string isn't terminated.
A raw string isn't correctly terminated because the trailing `#` count doesn't match its leading `#` count.

estebank · 2019-11-03T17:03:53Z

@GuillaumeGomez could the error code be in use by a recent commit? Have you tried rebasing against latest master?

GuillaumeGomez · 2019-11-04T09:47:27Z

I rebased before making the changes but I can retry.

GuillaumeGomez · 2019-11-06T12:10:31Z

Rebased so let's see now... (Running tests didn't change anything apparently)

rust-highfive · 2019-11-06T13:46:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-06T12:07:37.5248768Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-06T12:07:37.5429108Z ##[command]git config gc.auto 0
2019-11-06T12:07:37.5493646Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-06T12:07:37.5540489Z ##[command]git config --get-all http.proxy
2019-11-06T12:07:37.5682116Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66035/merge:refs/remotes/pull/66035/merge
---
2019-11-06T13:00:24.0363434Z .................................................................................................... 1600/9279
2019-11-06T13:00:29.1968990Z .................................................................................................... 1700/9279
2019-11-06T13:00:40.3924017Z ...............................................................i...............i.................... 1800/9279
2019-11-06T13:00:46.9131061Z .................................................................................................... 1900/9279
2019-11-06T13:01:00.4854870Z .....................................................iiiii.......................................... 2000/9279
2019-11-06T13:01:10.0542560Z .................................................................................................... 2200/9279
2019-11-06T13:01:12.2142653Z .................................................................................................... 2300/9279
2019-11-06T13:01:15.1895967Z .................................................................................................... 2400/9279
2019-11-06T13:01:36.0177136Z .................................................................................................... 2500/9279
2019-11-06T13:01:36.0177136Z .................................................................................................... 2500/9279
2019-11-06T13:01:38.5079254Z .................................................................................................... 2600/9279
2019-11-06T13:01:45.4191008Z .................................................................................................... 2700/9279
2019-11-06T13:01:53.5834232Z ......................i............................................................................. 2800/9279
2019-11-06T13:02:01.5786540Z .................................................................................................... 2900/9279
2019-11-06T13:02:05.6069593Z ....................i............................................................................... 3000/9279
2019-11-06T13:02:13.2132281Z .................................................................................................... 3100/9279
2019-11-06T13:02:18.1616948Z .................................................................................................... 3200/9279
2019-11-06T13:02:26.0659853Z ..ii................................................................................................ 3300/9279
2019-11-06T13:02:41.0864076Z ...............................................................................................i.... 3500/9279
2019-11-06T13:02:47.6387958Z ..........................................i......................................................... 3600/9279
2019-11-06T13:02:53.5476937Z .................................................................................................... 3700/9279
2019-11-06T13:02:59.3258148Z .................................................................................................... 3800/9279
---
2019-11-06T13:04:10.9704337Z .....................................................i...............i.............................. 4800/9279
2019-11-06T13:04:19.4062099Z .................................................................................................... 4900/9279
2019-11-06T13:04:27.3315733Z .................................................................................................... 5000/9279
2019-11-06T13:04:32.9242874Z .................................................................................................... 5100/9279
2019-11-06T13:04:42.5750463Z ......................................................ii.ii...........i............................. 5200/9279
2019-11-06T13:04:51.7363145Z .................................................................................................... 5400/9279
2019-11-06T13:05:01.3584010Z .................................................................................................... 5500/9279
2019-11-06T13:05:08.2772519Z ...........................i........................................................................ 5600/9279
2019-11-06T13:05:14.2432224Z .................................................................................................... 5700/9279
2019-11-06T13:05:14.2432224Z .................................................................................................... 5700/9279
2019-11-06T13:05:25.4350849Z .................................................................................................... 5800/9279
2019-11-06T13:05:36.3388969Z ............ii...i..ii...........i.................................................................. 5900/9279
2019-11-06T13:05:54.9119770Z .................................................................................................... 6100/9279
2019-11-06T13:06:02.3997670Z .................................................................................................... 6200/9279
2019-11-06T13:06:02.3997670Z .................................................................................................... 6200/9279
2019-11-06T13:06:15.1555015Z ...............................i..ii................................................................ 6300/9279
2019-11-06T13:06:34.2043498Z ..................................................................................................i. 6500/9279
2019-11-06T13:06:36.1947446Z .................................................................................................... 6600/9279
2019-11-06T13:06:38.1789295Z .............................................................................i...................... 6700/9279
2019-11-06T13:06:40.5755163Z .................................................................................................... 6800/9279
---
2019-11-06T13:11:30.0886422Z finished in 5.022
2019-11-06T13:11:30.1062720Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:11:30.2501896Z 2019-11-06T13:11:30.2502033Z running 158 tests
2019-11-06T13:11:32.9877711Z iiiiii....iii......iii..iiii...i.............................i..i..................i....i........... 100/158
2019-11-06T13:11:34.7615874Z ii.i.i..iiii..............i.........iii.i.........ii......
2019-11-06T13:11:34.7616301Z 2019-11-06T13:11:34.7620808Z finished in 4.655
2019-11-06T13:11:34.7780503Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:11:34.9171706Z ---
2019-11-06T13:11:36.7806681Z finished in 2.002
2019-11-06T13:11:36.7962379Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:11:36.9324927Z 2019-11-06T13:11:36.9325074Z running 9 tests
2019-11-06T13:11:36.9326912Z iiiiiiiii
2019-11-06T13:11:36.9328042Z 2019-11-06T13:11:36.9329583Z finished in 0.136
2019-11-06T13:11:36.9488899Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:11:37.0978381Z ---
2019-11-06T13:11:55.0357811Z finished in 17.360
2019-11-06T13:11:55.0358160Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:11:55.0358200Z 2019-11-06T13:11:55.0358269Z running 123 tests
2019-11-06T13:12:16.5369891Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-11-06T13:12:20.1463810Z i.i.i......iii.i.....ii
2019-11-06T13:12:20.1464912Z 2019-11-06T13:12:20.1470133Z finished in 25.820
2019-11-06T13:12:20.1477952Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-06T13:12:20.1478303Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-06T13:23:37.7084670Z 2019-11-06T13:23:37.7093987Z Doc-tests core
2019-11-06T13:23:42.2456094Z 2019-11-06T13:23:42.2473032Z running 2417 tests
2019-11-06T13:23:52.3194073Z ......iiiii......................................................................................... 100/2417
2019-11-06T13:24:02.2119462Z ................................................................................ii.................. 200/2417
2019-11-06T13:24:25.2346409Z ..i................................................................................................. 400/2417
2019-11-06T13:24:25.2346409Z ..i................................................................................................. 400/2417
2019-11-06T13:24:34.9857431Z ..................................................i..i.................iiii......................... 500/2417
2019-11-06T13:24:53.2222344Z .................................................................................................... 700/2417
2019-11-06T13:25:02.7310673Z .................................................................................................... 800/2417
2019-11-06T13:25:12.2943172Z .................................................................................................... 900/2417
2019-11-06T13:25:21.8695420Z .................................................................................................... 1000/2417
---
2019-11-06T13:28:59.9509626Z ............................................... 300/763
2019-11-06T13:28:59.9563787Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-11-06T13:28:59.9994115Z .................................................................................................... 400/763
2019-11-06T13:29:02.0673206Z .................................................................................................... 500/763
2019-11-06T13:29:02.0908413Z ....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.0937267Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.0949934Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.0975441Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.4020811Z ............................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.4035150Z ...thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"thread '', <unnamed>src/libcore/result.rs:1165:5
2019-11-06T13:29:02.4046772Z ...' panicked at '.called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:02.4056898Z ...thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1165:5
2019-11-06T13:29:04.4469801Z .........................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-11-06T13:29:04.4481807Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-11-06T13:29:04.4482436Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-11-06T13:29:04.4483271Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-11-06T13:29:13.6701506Z 2019-11-06T13:29:13.6702298Z running 1000 tests
2019-11-06T13:29:33.0290005Z i................................................................................................... 100/1000
2019-11-06T13:29:43.8651122Z .................................................................................................... 200/1000
2019-11-06T13:29:51.7344277Z ...................iii......i......i...i......i..................................................... 300/1000
2019-11-06T13:29:57.0320049Z .................................................................................................... 400/1000
2019-11-06T13:30:04.4164085Z ...........................................i..i.................................ii.................. 500/1000
2019-11-06T13:30:18.0773688Z .................................................................................................... 700/1000
2019-11-06T13:30:18.0773688Z .................................................................................................... 700/1000
2019-11-06T13:30:25.3368842Z ..........................iiii...................................................................... 800/1000
2019-11-06T13:30:40.0487212Z .................................................................................................... 900/1000
2019-11-06T13:30:47.4227345Z ................................................iiii................................................ 1000/1000
2019-11-06T13:30:47.4228364Z test result: ok. 980 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2019-11-06T13:30:47.4228447Z 2019-11-06T13:30:47.4314356Z finished in 179.812
2019-11-06T13:30:47.4328960Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-11-06T13:45:59.2899498Z Compiling error_index_generator v0.0.0 (/checkout/src/tools/error_index_generator)
2019-11-06T13:46:05.6857561Z Finished release [optimized] target(s) in 8.08s
2019-11-06T13:46:05.7757716Z 2019-11-06T13:46:05.7758141Z 2019-11-06T13:46:05.7758863Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/error_index_generator" "html" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc/error-index.html" "1.40.0"
2019-11-06T13:46:05.7759376Z 2019-11-06T13:46:05.7759534Z 2019-11-06T13:46:05.7765085Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-06T13:46:05.7765363Z Build completed unsuccessfully in 1:32:00
2019-11-06T13:46:05.7765363Z Build completed unsuccessfully in 1:32:00
2019-11-06T13:46:05.7811402Z == clock drift check ==
2019-11-06T13:46:05.7825395Z local time: Wed Nov 6 13:46:05 UTC 2019
2019-11-06T13:46:06.5706958Z network time: Wed, 06 Nov 2019 13:46:06 GMT
2019-11-06T13:46:06.5707032Z == end clock drift check ==
2019-11-06T13:46:12.4276816Z 2019-11-06T13:46:12.4365302Z ##[error]Bash exited with code '1'.
2019-11-06T13:46:12.4394560Z ##[section]Starting: Checkout
2019-11-06T13:46:12.4396054Z ==============================================================================
2019-11-06T13:46:12.4396113Z Task : Get sources
2019-11-06T13:46:12.4396148Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

GuillaumeGomez · 2019-11-06T17:02:52Z

Since failing on the error code index generator. I'll definitely need to check what's going on more deeply because the logs aren't helping.

bors · 2019-11-10T15:55:39Z

☔ The latest upstream changes (presumably #65324) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2019-11-10T23:49:47Z

The error is actually coming from pulldown_cmark (the html::push_html function to be exact).

GuillaumeGomez · 2019-11-11T00:00:36Z

And the problem seems to be fixed in the next pulldown_cmark version so let's wait for #65894 to get merged first...

estebank · 2019-11-14T00:36:20Z

r=me after rebase and green ci

GuillaumeGomez · 2019-11-14T09:36:19Z

Waiting for #66314 to be merged first then need to update the error code number (E0744 has been taken in the meantime).

JohnCSimon · 2019-11-24T01:46:44Z

Ping from triage
@GuillaumeGomez #66314 has been merged...
Can you please address the merge conflicts?

GuillaumeGomez · 2019-11-24T11:33:41Z

For now it's useless considering I'm waiting for another PR to get merged.

GuillaumeGomez · 2019-11-27T14:12:25Z

Still blocked on #65894.

@estebank

…or,estebank Create E0747 error code for unterminated raw strings Reopening of #66035. r? @estebank

rust-highfive assigned eddyb Nov 2, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2019

rust-highfive assigned estebank and unassigned eddyb Nov 2, 2019

estebank reviewed Nov 3, 2019
View reviewed changes

GuillaumeGomez added 2 commits November 6, 2019 10:41

Add error code E744 for unterminated raw string
26fe3f5

update ui tests
eec598a

GuillaumeGomez force-pushed the create-E0744-error-code branch from 7245bb9 to eec598aCompare November 6, 2019 12:07

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019

Dylan-DPC-zz added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2019

Others mentioned this pull request Jan 31, 2020
Add boolean to tell if it's an indented code block or not pulldown-cmark/pulldown-cmark#416
Merged

GuillaumeGomez closed this Feb 18, 2020

GuillaumeGomez mentioned this pull request Feb 18, 2020
Create E0748 error code for unterminated raw strings #69260
Merged

bors added a commit that referenced this pull request Feb 29, 2020
Auto merge of#69260- GuillaumeGomez:create-E0747-error-code, r=vark…
e9bca51
…or,estebank Create E0747 error code for unterminated raw strings Reopening of #66035. r? @estebank

GuillaumeGomez deleted the create-E0744-error-code branch August 19, 2024 12:24

	A raw string isn't terminated.
	A raw string isn't correctly terminated because the trailing `#` count doesn't match its leading `#` count.

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Nov 2, 2019

Uh oh!

rust-highfive commented Nov 2, 2019

Uh oh!

rust-highfive commented Nov 2, 2019

Uh oh!

rust-highfive commented Nov 2, 2019

Uh oh!

GuillaumeGomez commented Nov 2, 2019

Uh oh!

eddyb commented Nov 2, 2019

Uh oh!

estebankNov 3, 2019

Choose a reason for hiding this comment

Uh oh!

estebank commented Nov 3, 2019

Uh oh!

GuillaumeGomez commented Nov 4, 2019

Uh oh!

GuillaumeGomez commented Nov 6, 2019

Uh oh!

rust-highfive commented Nov 6, 2019

Uh oh!

GuillaumeGomez commented Nov 6, 2019

Uh oh!

bors commented Nov 10, 2019

Uh oh!

GuillaumeGomez commented Nov 10, 2019

Uh oh!

GuillaumeGomez commented Nov 11, 2019

Uh oh!

estebank commented Nov 14, 2019

Uh oh!

GuillaumeGomez commented Nov 14, 2019

Uh oh!

JohnCSimon commented Nov 24, 2019

Uh oh!

GuillaumeGomez commented Nov 24, 2019

Uh oh!

GuillaumeGomez commented Nov 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants