Uh oh!
There was an error while loading. Please reload this page.
Create E0748 error code for unterminated raw strings - #69260
Merged
Conversation
rust-highfive
commented
Feb 18, 2020
Contributor
Some changes occurred in diagnostic error codes |
Xanewok
approved these changes
Feb 18, 2020
GuillaumeGomez
commented
Feb 26, 2020
MemberAuthor
cc @rust-lang/compiler |
varkor
approved these changes
Feb 26, 2020
varkor
left a comment
Contributor
There was a problem hiding this comment.
r=me with tweaked sentence.
Contributor
There was a problem hiding this comment.
Suggested change
| than at the beginning. Example: | |
| as at the beginning. Example: |
Comment on lines
12
to
13
Contributor
There was a problem hiding this comment.
Suggested change
| let dolphins = r#"Dolphins!"#; // one`#` at the beginning, one at the end so | |
| // all good! | |
| let dolphins = r#"Dolphins!"#; // One`#` at the beginning; one at the end: | |
| // all good! |
estebank
approved these changes
Feb 27, 2020
estebank
commented
Feb 27, 2020
Contributor
also r=me after applying varkor's changes |
GuillaumeGomez
commented
Feb 27, 2020
MemberAuthor
@bors: r=varkor,estebank |
bors
commented
Feb 27, 2020
Collaborator
📌 Commit e2da93acb2432c26a74ea83128d72884d8b0cdf3 has been approved by |
bors
commented
Feb 27, 2020
Collaborator
☔ The latest upstream changes (presumably #68434) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
commented
Feb 28, 2020
MemberAuthor
E0747 has been taken so let's move to E0748... |
GuillaumeGomezforce-pushed
the
create-E0747-error-code
branch
from
February 28, 2020 15:01
e2da93a to
e273828CompareGuillaumeGomez
commented
Feb 28, 2020
MemberAuthor
@bors: r=varkor,estebank |
bors
commented
Feb 28, 2020
Collaborator
📌 Commit e273828 has been approved by |
bors
commented
Feb 29, 2020
Collaborator
bors
commented
Feb 29, 2020
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Feb 29, 2020
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 29, 2020
Tested on commit rust-lang/rust@e9bca51. Direct link to PR: <rust-lang/rust#69260> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening of #66035.
r? @estebank