Initial implementation of or-pattern usefulness checking by Nadrieril · Pull Request #66612 · rust-lang/rust

Nadrieril · 2019-11-21T18:56:47Z

The title says it all.
I'd like to request a perf run on that, hopefully this doesn't kill performance too much.

cc #54883

Centril · 2019-11-21T19:07:29Z

r? @varkor cc @arielb1

@bors try @rust-timer queue

rust-timer · 2019-11-21T19:07:30Z

Awaiting bors try build completion

bors · 2019-11-22T22:01:27Z

⌛ Trying commit 0030a77 with merge 320df38...

Initial implementation of or-pattern usefulness checking The title says it all. I'd like to request a perf run on that, hopefully this doesn't kill performance too much. cc #54883

bors · 2019-11-23T00:18:22Z

☀️ Try build successful - checks-azure
Build commit: 320df38 (320df38ba09a0ebc7c7861ef004719810c60ae1f)

rust-timer · 2019-11-23T00:18:24Z

Queued 320df38 with parent 5fa0af2, future comparison URL.

rust-timer · 2019-11-23T13:41:43Z

Finished benchmarking try commit 320df38, comparison URL.

Centril · 2019-11-29T18:08:33Z

+ }
+
+ match (0u8,) {
+ (1 | 1,) => {} // redundancy not detected for now


I assume you have plans for this somehow... =P

I do ^^. This is actually necessary if we want to remove the hack for top-level or-patterns and keep the same diagnostics. I'll have a follow-up PR up soon

Centril

Looks good as an initial implementation but then again the algorithm in _match.rs is not something I'm really familiar with so @varkor should do the approving.

varkor

Changes look good — r=me with the nits fixed.

Co-Authored-By: varkor <github@varkor.com>

varkor · 2019-11-30T14:08:33Z

Great, thank you very much for working on this!

@bors r+

bors · 2019-11-30T14:08:34Z

📌 Commit 0f4c5fb has been approved by varkor

bors · 2019-11-30T14:08:35Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

…rkor Initial implementation of or-pattern usefulness checking The title says it all. I'd like to request a perf run on that, hopefully this doesn't kill performance too much. cc rust-lang#54883

@ghost

Rollup of 9 pull requests Successful merges: - #66612 (Initial implementation of or-pattern usefulness checking) - #66705 (Atomic as_mut_ptr) - #66759 (impl TrustedLen for vec::Drain) - #66858 (Use LLVMAddAnalysisPasses instead of Rust's wrapper) - #66870 (SimplifyArmIdentity only for locals with the same type) - #66883 (rustc_typeck: gate AnonConst's generics on feature(const_generics).) - #66889 (Make python-generated source files compatible with rustfmt) - #66894 (Remove unneeded prelude imports in libcore tests) - #66895 (Feature gating *declarations* => new crate `rustc_feature`) Failed merges: - #66905 (rustc_plugin: Remove some remaining plugin features) r? @ghost

bors · 2019-12-01T03:40:10Z

☔ The latest upstream changes (presumably #66908) made this pull request unmergeable. Please resolve the merge conflicts.

Nadrieril · 2019-12-01T18:30:37Z

I'm confused, bors merged the PR and then detected a conflict with itself ? Is that a false positive from bors or do I need to rebase on master ?

Centril · 2019-12-01T18:50:59Z

That's a false positive from the buggy bors; no need to do anything.

@varkor

Remove hack for top-level or-patterns in match checking Follow-up to rust-lang#66612. Or-patterns are now truly first-class in match checking. As a side-effect, redundant subpatterns are linted as such, making the `unreachable_patterns` lint a bit more general. cc rust-lang#54883 r? @varkor

@varkor

Remove hack for top-level or-patterns in match checking Follow-up to rust-lang#66612. Or-patterns are now truly first-class in match checking. As a side-effect, redundant subpatterns are linted as such, making the `unreachable_patterns` lint a bit more general. cc rust-lang#54883 r? @varkor

mark-i-m · 2019-12-05T01:30:02Z

the buggy bors

😱 How dare you insult the @bors 💥 HE SEES ALLLLLLLLLL

cc rust-lang/rfcs#2671

Initial implementation of or-pattern usefulness checking
6e85f46

rust-highfive assigned matthewjasper Nov 21, 2019

This comment has been minimized.
Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2019

Add some more tests
0030a77

rust-highfive assigned varkor and unassigned matthewjasper Nov 21, 2019

This comment has been minimized.
Sign in to view

matthewjasper reviewed Nov 21, 2019
View reviewed changes

Comment threadsrc/librustc_mir/hair/pattern/_match.rs Outdated

Centril reviewed Nov 21, 2019
View reviewed changes

Comment threadsrc/librustc_mir/hair/pattern/_match.rs Outdated

Centril reviewed Nov 21, 2019
View reviewed changes

Comment threadsrc/test/compile-fail/or-patterns.rs Outdated
Comment threadsrc/test/compile-fail/or-patterns.rs
Comment threadsrc/test/compile-fail/or-patterns.rs

Centril added the F-or_patterns `#![feature(or_patterns)]` label Nov 21, 2019

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2019

Centril mentioned this pull request Nov 22, 2019
Tracking issue for RFC 2535, 2530, 2175, "Or patterns, i.e Foo(Bar(x) | Baz(x))" #54883
Closed
8 tasks

This comment has been minimized.
Sign in to view

Nadrieril requested a review from Centril November 29, 2019 17:24

Centril reviewed Nov 29, 2019
View reviewed changes

Centril approved these changes Nov 29, 2019
View reviewed changes

varkor approved these changes Nov 30, 2019
View reviewed changes

Comment threadsrc/librustc_mir/hair/pattern/_match.rs Outdated
Comment threadsrc/librustc_mir/hair/pattern/_match.rs Outdated
Comment threadsrc/test/ui/or-patterns/exhaustiveness-pass.rs Outdated

Apply suggestions from code review
0f4c5fb
Co-Authored-By: varkor <github@varkor.com>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2019

Centril mentioned this pull request Nov 30, 2019
Rollup of 9 pull requests #66908
Merged

bors merged commit 0f4c5fb into rust-lang:masterDec 1, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 1, 2019

Nadrieril deleted the or-patterns-initial branch December 2, 2019 15:32

Nadrieril mentioned this pull request Dec 2, 2019
Remove hack for top-level or-patterns in match checking #66967
Merged

Nadrieril added the A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns label Dec 10, 2023

Uh oh!

Uh oh!

Conversation

Nadrieril commented Nov 21, 2019• edited by Centril Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Centril commented Nov 21, 2019

Uh oh!

rust-timer commented Nov 21, 2019

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Nov 22, 2019

Uh oh!

This comment has been minimized.

bors commented Nov 23, 2019

Uh oh!

rust-timer commented Nov 23, 2019

Uh oh!

rust-timer commented Nov 23, 2019

Uh oh!

CentrilNov 29, 2019

Choose a reason for hiding this comment

Uh oh!

NadrierilNov 30, 2019

Choose a reason for hiding this comment

Uh oh!

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

varkor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varkor commented Nov 30, 2019

Uh oh!

bors commented Nov 30, 2019

Uh oh!

bors commented Nov 30, 2019

Uh oh!

bors commented Dec 1, 2019

Uh oh!

Nadrieril commented Dec 1, 2019

Uh oh!

Centril commented Dec 1, 2019

Uh oh!

mark-i-m commented Dec 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Nadrieril commented Nov 21, 2019•
edited by Centril
Loading